share: don't reinitialize conncache

[ericnorris]

Recently I was messing around with the idea of enabling persistent Curl_share structs in PHP, i.e. to be able to reuse the same instance of the struct across multiple requests in a single mod_php worker.

This worked something like the following (note that this is PHP, not C):

$sh = curl_share_init("some-persistent-id");

curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_DNS);
curl_share_setopt($sh, CURLSHOPT_SHARE, CURL_LOCK_DATA_CONNECT);
// ...etc

I noticed, however, that CURL_LOCK_DATA_CONNECT wasn't working across multiple requests in a mod_php worker. It did work if I made sure to only ever call curl_share_setopt on the very first request, which led me to look into the definition of curl_share_setopt.

I noticed that unlike other options - CURL_LOCK_DATA_SSL_SESSION, for example - CURL_LOCK_DATA_CONNECT wasn't checking to see if the connection cache had already been initialized.

Regardless of whether I continue to work on the PHP stuff, I figured it would be a simple change to check for this. It wasn't clear to me what the best way was to check if the connection cache was already initialized, so let me know if you have a preference for a better way.

[ericnorris]

I ran make test locally, but it seems these tests are failing on the line length, I'll update that.

[icing]

Thanks, that is a good catch. If we do this for sessions, we should do this idempotent behaviour for the connection cache as well.

[bagder]

Thanks!