Repository navigation
Conversation
Drop Apple-specific detection logic for `poll()`. This detection snippet has been disabled for Apple in both configure and cmake, for `poll()` being broken on Apple since 10.12 Sierra (2016). Also replace `exit(1);` with `return 1;` in configure, to make the snippets match.
vszakats
marked this pull request as draft
August 29, 2024 08:24
vszakats
changed the title
vszakats
changed the title
vszakats
changed the title
poll()
vszakats
marked this pull request as ready for review
August 29, 2024 08:30
bagder
approved these changes
Aug 29, 2024
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 29, 2024
Also: - cmake: delete unnecessary `#include <sys/time.h>` from non-cross-build `poll()` detection snippet. Follow-up tp cc8b813 curl#14718 Fixes curl#14714
vszakats
added a commit
that referenced
this pull request
Aug 30, 2024
For cross-builds rely on `_POSIX_C_SOURCE` to decide if `poll()` is supported, rather than just assuming it isn't. This may still miss to detect `poll()` support, as seen for example with Linux MUSL cross-builds. Also: - GHA/curl-for-win: enable RISC-V 64 cross-target for Linux MUSL. (to test this case with cmake, with a false-negative.) The first RISC-V 64 build in curl's CI. - GHA/curl-for-win: add arm64/intel64 job for Linux glibc. (to test this case with cmake, and succeed.) - cmake: delete unnecessary `#include <sys/time.h>` from non-cross-build `poll()` detection snippet. Follow-up tp cc8b813 #14718 Fixes #14714 Closes #14734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop Apple-specific detection logic for
poll(). This detection snippethas been disabled for Apple in both configure and cmake, for
poll()being broken on Apple since 10.12 Sierra (2016).
Also replace
exit(1);withreturn 1;in configure, to make thesnippets match.
Added in 9297ca4 #1057 (2016-10-11).
Disabled for:
configure/darwin in a34c7ce (2016-10-18)
cmake/macOS in 825911b #7619
cmake/iOS in d148312 #8244
cmake/all Apple in a86254b #12515