curl: show the libcurl release date in --version output - #1474
Conversation
|
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @captain-caveman2k and @michael-o to be potential reviewers. |
|
Counterproposal, be language-agnostic, use ISO 8601: |
Not a bad idea... |
|
...and the reason for rejecting? |
8d4c69a to
90ec603
Compare
|
Isn't |
Yes I think that looks better. And with the shorter date format the line is still reasonably sized. I also think I need to come up with something nicer when building from git as right now it makes the date become "DEV" which I'm sure will cause some issues going forward. |
90ec603 to
16e6352
Compare
|
Pushed on update now that uses |
|
That's implied with DEV, why not just suppress the line in that case |
|
You think suppressing is better? I actually like seeing and stating that it isn't a "blessed" release build and suppressing it makes it less obvious... It occurred to me after my last update here that I could get an |
... and support and additional "security patched" date for those who enhance older versions that way. Pass on the define CURL_PATCHSTAMP with a date for that. Building with non-release headers shows the date as [unreleased]. Also: this changes the date format generated in the curlver.h file to be "YYYY-MM-DD" (no name of the day or month, no time, no time zone) to make it easier on the eye and easier to parse. Example (new) date string: 2017-05-09 Suggested-by: Brian Childs
16e6352 to
ac35a50
Compare
ok |
4 participants
... and support and additional "security patched" date for those who
enhance older versions that way.
Also: change the date format generated in the
curlver.hfile to only be"NNN DD YYYY" (no name of day, no time, no time zone) to make it easier
on the eye and easier to parse. Example (new) date string: "May 09
2017".
Suggested-by: Brian Childs