New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: show the libcurl release date in --version output #1474

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@bagder
Member

bagder commented May 9, 2017

... and support and additional "security patched" date for those who
enhance older versions that way.

Also: change the date format generated in the curlver.h file to only be
"NNN DD YYYY" (no name of day, no time, no time zone) to make it easier
on the eye and easier to parse. Example (new) date string: "May 09
2017".

Suggested-by: Brian Childs

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 9, 2017

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @captain-caveman2k and @michael-o to be potential reviewers.

mention-bot commented May 9, 2017

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @captain-caveman2k and @michael-o to be potential reviewers.

@michael-o

This comment has been minimized.

Show comment
Hide comment
@michael-o

michael-o May 9, 2017

Member

Counterproposal, be language-agnostic, use ISO 8601: %F

Member

michael-o commented May 9, 2017

Counterproposal, be language-agnostic, use ISO 8601: %F

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 9, 2017

Member

use ISO 8601: %F

Not a bad idea...

Member

bagder commented May 9, 2017

use ISO 8601: %F

Not a bad idea...

@michael-o

This comment has been minimized.

Show comment
Hide comment
@michael-o

michael-o May 9, 2017

Member

...and the reason for rejecting?

Member

michael-o commented May 9, 2017

...and the reason for rejecting?

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay May 11, 2017

Member

Isn't Date: a bit ambiguous, it could mean compile date or release date. How about Release-Date:

Member

jay commented May 11, 2017

Isn't Date: a bit ambiguous, it could mean compile date or release date. How about Release-Date:

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 11, 2017

Member

How about Release-Date:

Yes I think that looks better. And with the shorter date format the line is still reasonably sized.

I also think I need to come up with something nicer when building from git as right now it makes the date become "DEV" which I'm sure will cause some issues going forward.

Member

bagder commented May 11, 2017

How about Release-Date:

Yes I think that looks better. And with the shorter date format the line is still reasonably sized.

I also think I need to come up with something nicer when building from git as right now it makes the date become "DEV" which I'm sure will cause some issues going forward.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 11, 2017

Member

Pushed on update now that uses Release-Date: and when building from non-released headers it uses the date [unreleased]...

Member

bagder commented May 11, 2017

Pushed on update now that uses Release-Date: and when building from non-released headers it uses the date [unreleased]...

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay May 11, 2017

Member

That's implied with DEV, why not just suppress the line in that case

Member

jay commented May 11, 2017

That's implied with DEV, why not just suppress the line in that case

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 11, 2017

Member

You think suppressing is better? I actually like seeing and stating that it isn't a "blessed" release build and suppressing it makes it less obvious...

It occurred to me after my last update here that I could get an [unrelased] date string in there simply by changing DEV in the header so I might do that...

Member

bagder commented May 11, 2017

You think suppressing is better? I actually like seeing and stating that it isn't a "blessed" release build and suppressing it makes it less obvious...

It occurred to me after my last update here that I could get an [unrelased] date string in there simply by changing DEV in the header so I might do that...

curl: show the libcurl release date in --version output
... and support and additional "security patched" date for those who
enhance older versions that way. Pass on the define CURL_PATCHSTAMP with
a date for that.

Building with non-release headers shows the date as [unreleased].

Also: this changes the date format generated in the curlver.h file to be
"YYYY-MM-DD" (no name of the day or month, no time, no time zone) to
make it easier on the eye and easier to parse. Example (new) date
string: 2017-05-09

Suggested-by: Brian Childs
@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay May 12, 2017

Member

It occurred to me after my last update here that I could get an [unrelased] date string in there simply by changing DEV in the header so I might do that...

ok

Member

jay commented May 12, 2017

It occurred to me after my last update here that I could get an [unrelased] date string in there simply by changing DEV in the header so I might do that...

ok

@bagder bagder closed this in 180c75e May 14, 2017

@bagder bagder deleted the bagder/curl-version-date branch May 14, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.