Skip to content

lib: remove use of RANDOM_FILE - #14749

Closed
bagder wants to merge 4 commits into
masterfrom
bagder/rm-RANDOM_FILE
Closed

bagder wants to merge 4 commits into
masterfrom
bagder/rm-RANDOM_FILE

Conversation

@bagder

@bagder bagder commented Aug 31, 2024

Copy link
Copy Markdown
Member

It could previously be set with configure/cmake and used in rare cases for reading randomness: with ancient mbedTLS or rustls without arc4random.

We now get randomness in this order:

  1. The TLS library's way to provide random
  2. On Windows: Curl_win32_random
  3. if arc4random exists, use that
  4. weak non-crytographically strong pseudo-random

@bagder
bagder force-pushed the bagder/rm-RANDOM_FILE branch from 683ad93 to 08b1e7b Compare August 31, 2024 21:14
@bagder
bagder marked this pull request as draft August 31, 2024 21:57
@bagder
bagder force-pushed the bagder/rm-RANDOM_FILE branch from 56778a8 to 141782f Compare August 31, 2024 22:01
@bagder
bagder marked this pull request as ready for review September 1, 2024 08:03
It could previously be set with configure/cmake and used in rare cases
for reading randomness: with ancient mbedTLS or rustls without
arc4random.

We now get randomness in this order:

1. The TLS library's way to provide random
2. On Windows: Curl_win32_random
3. if arc4random exists, use that
4. weak non-crytographically strong pseudo-random

Closes #14749
builds without TLS and builds using rustls

Closes #14749
@bagder
bagder force-pushed the bagder/rm-RANDOM_FILE branch from e43e4fb to dc977bc Compare September 2, 2024 08:54
@bagder bagder closed this in 269fdd4 Sep 2, 2024
bagder added a commit that referenced this pull request Sep 2, 2024
builds without TLS and builds using rustls

Closes #14749
@bagder
bagder deleted the bagder/rm-RANDOM_FILE branch September 2, 2024 16:43
vszakats added a commit to curl/curl-for-win that referenced this pull request Sep 2, 2024
Not disablable in 8.9.1 and gone completely in 8.10.0:

curl/curl#14749
curl/curl@d76b648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant