Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove use of RANDOM_FILE #14749

Closed
wants to merge 4 commits into from
Closed

lib: remove use of RANDOM_FILE #14749

wants to merge 4 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Aug 31, 2024

It could previously be set with configure/cmake and used in rare cases for reading randomness: with ancient mbedTLS or rustls without arc4random.

We now get randomness in this order:

  1. The TLS library's way to provide random
  2. On Windows: Curl_win32_random
  3. if arc4random exists, use that
  4. weak non-crytographically strong pseudo-random

bagder added a commit that referenced this pull request Aug 31, 2024
It could previously be set with configure/cmake and used in rare cases
for reading randomness: with ancient mbedTLS or rustls without
arc4random.

We now get randomness in this order:

1. The TLS library's way to provide random
2. On Windows: Curl_win32_random
3. if arc4random exists, use that
4. weak non-crytographically strong pseudo-random

Closes #14749
@bagder bagder marked this pull request as draft August 31, 2024 21:57
@bagder bagder marked this pull request as ready for review September 1, 2024 08:03
It could previously be set with configure/cmake and used in rare cases
for reading randomness: with ancient mbedTLS or rustls without
arc4random.

We now get randomness in this order:

1. The TLS library's way to provide random
2. On Windows: Curl_win32_random
3. if arc4random exists, use that
4. weak non-crytographically strong pseudo-random

Closes #14749
builds without TLS and builds using rustls

Closes #14749
@bagder bagder closed this in 269fdd4 Sep 2, 2024
bagder added a commit that referenced this pull request Sep 2, 2024
builds without TLS and builds using rustls

Closes #14749
@bagder bagder deleted the bagder/rm-RANDOM_FILE branch September 2, 2024 16:43
vszakats added a commit to curl/curl-for-win that referenced this pull request Sep 2, 2024
Not disablable in 8.9.1 and gone completely in 8.10.0:

curl/curl#14749
curl/curl@d76b648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant