Skip to content

docs: document the (weak) random value situation in rustls builds - #14770

Closed
bagder wants to merge 5 commits into
masterfrom
bagder/rustls-random
Closed

bagder wants to merge 5 commits into
masterfrom
bagder/rustls-random

Conversation

@bagder

@bagder bagder commented Sep 3, 2024

Copy link
Copy Markdown
Member

No description provided.

Comment thread docs/RUSTLS.md Outdated
spelling

Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
Comment thread docs/RUSTLS.md Outdated
Uppercase Rustls

Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
@bagder bagder closed this in 9e629a1 Sep 3, 2024
@bagder
bagder deleted the bagder/rustls-random branch September 3, 2024 14:49
@ctz

ctz commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

We will address this.

@cpu

cpu commented Sep 9, 2024 •

Copy link
Copy Markdown
Contributor

Would you be open to tagging a Rustls dev when you bump into these sorts of issues? I hate to make more work for the curl folks but this sort of thing can fly under the radar otherwise. I spotted it by chance when looking at git log while curious about another topic. The curl repo is tricky to set a global watch on because y'all are too productive 😆

@bagder

bagder commented Sep 9, 2024

Copy link
Copy Markdown
Member Author

@cpu sure, if you have any preference for who/how to tag you, I could certainly make an effort to!

@cpu

cpu commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

any preference for who/how to tag you

You can definitely tag me liberally. I'll let ctz decide himself if he wants the notifications :-)

Beyond bugs/issues I'm also happy to give non-blocking reviews on Rustls-related PRs like #14535 It's helpful to see where our APIs might be awkward/underdocumented.

@ctz

ctz commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

Please do tag me too.

@cpu

cpu commented Sep 10, 2024

Copy link
Copy Markdown
Contributor

We landed a capability for this upstream in the yet-to-be-released rustls-ffi 0.14. I will pick up a fix for the curl side along with an update for the relevant breaking changes once we cut a release. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants