Repository navigation
Conversation
If there is a (memory) error when creating the certinfo data, the code would previously continue which could lead to a partial/broken response. Now, the first error aborts and cleans up the entire thing. A certinfo "collection" error is however still not considered an error big enough to stop the handshake. Bonus: made two functions static (and removed the Curl_ prefix) that were not used outside of openssl.c
Contributor
|
Analysis of PR #14780 at 7fd43d88: Test 1120 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Test 1540 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a (memory) error when creating the certinfo data, the code would previously continue which could lead to a partial/broken response. Now, the first error aborts and cleans up the entire thing.
A certinfo "collection" error is however still not considered an error big enough to stop the handshake.
Bonus: made two functions static (and removed the Curl_ prefix) that were not used outside of openssl.c
Bonus 2: removed the unused function
Curl_ossl_set_client_cert