Repository navigation
Conversation
Since the value is already supposed to be correct, verify that with and assert instead of doing an assign that is not needed. Bonus: removing unnecessary clearing of data
Contributor
|
Analysis of PR #14784 at 9a4f34a6: Test 3100 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the value is already supposed to be correct, verify that with an assert instead of doing an assign that is not needed.
Bonus: removing unnecessary clearing of data