Skip to content

smb: convert superflous assign into assert #14784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 4, 2024

Since the value is already supposed to be correct, verify that with an assert instead of doing an assign that is not needed.

Bonus: removing unnecessary clearing of data

Since the value is already supposed to be correct, verify that with and
assert instead of doing an assign that is not needed.

Bonus: removing unnecessary clearing of data
@github-actions github-actions bot added the SMB label Sep 4, 2024
@dfandrich
Copy link
Contributor

Analysis of PR #14784 at 9a4f34a6:

Test 3100 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Generated by Testclutch

@bagder bagder closed this in 464d466 Sep 5, 2024
@bagder bagder deleted the bagder/smb-assert branch September 5, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants