Repository navigation
Conversation
lib/http.h and src/tool_sdecls.h both declared `HTTPREQ_*` enums. These were used in the same source till now. They do now when building bundling up unit tests into a single source file.
vszakats
force-pushed
the
src-lib-enum-clash
branch
from
September 4, 2024 12:50
167b901 to
d2ce767
Compare
bagder
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/http.handsrc/tool_sdecls.hboth declaredHTTPREQ_*enums.
Rename
srcones to have distinct names.They are not included in the same code for now, but this may
change when bundling unit/libtests into single programs. But I
figure it'd be nice to make these unique regardless.
Question: Would it be better to merge them and move them to
curl_setup.hor someplace shared betweenlibandsrc?curl/lib/http.h
Lines 36 to 43 in 6a9b710
curl/src/tool_sdecls.h
Lines 116 to 123 in 6a9b710