src: namespace symbols clashing with lib #14785
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/http.h
andsrc/tool_sdecls.h
both declaredHTTPREQ_*
enums.
Rename
src
ones to have distinct names.They are not included in the same code for now, but this may
change when bundling unit/libtests into single programs. But I
figure it'd be nice to make these unique regardless.
Question: Would it be better to merge them and move them to
curl_setup.h
or someplace shared betweenlib
andsrc
?curl/lib/http.h
Lines 36 to 43 in 6a9b710
curl/src/tool_sdecls.h
Lines 116 to 123 in 6a9b710