Repository navigation
Conversation
The daily snapshots have no associated git tag, so provide a commit has instead in these cases. Fix the dpkg detection since the shell would exit immediately without showing an error message if it weren't found. Also, use "which" instead of "command" since the latter is bash-specific and this script specifies a plain Bourne shell. Closes #14820
dfandrich
force-pushed
the
dfandrich/release-tools
branch
from
September 7, 2024 02:23
d8a23d7 to
70efbcb
Compare
Contributor
Author
|
shellcheck tells me |
Contributor
Author
|
Analysis of PR #14820 at 70efbcba: Test 721 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Test 2055 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
bagder
approved these changes
Sep 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily snapshots have no associated git tag, so provide a commit has
instead in these cases. Fix the dpkg detection since the shell would
exit immediately without showing an error message if it weren't found.
Also, use "which" instead of "command" since the latter is bash-specific
and this script specifies a plain Bourne shell.
Closes #14820