Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maketgz: fix RELEASE-TOOLS.md for daily tarballs #14820

Closed
wants to merge 1 commit into from

Conversation

dfandrich
Copy link
Contributor

The daily snapshots have no associated git tag, so provide a commit has
instead in these cases. Fix the dpkg detection since the shell would
exit immediately without showing an error message if it weren't found.
Also, use "which" instead of "command" since the latter is bash-specific
and this script specifies a plain Bourne shell.

Closes #14820

@github-actions github-actions bot added the script label Sep 7, 2024
The daily snapshots have no associated git tag, so provide a commit has
instead in these cases. Fix the dpkg detection since the shell would
exit immediately without showing an error message if it weren't found.
Also, use "which" instead of "command" since the latter is bash-specific
and this script specifies a plain Bourne shell.

Closes #14820
@dfandrich
Copy link
Contributor Author

shellcheck tells me command is more portable than which, so I switched that back.

@dfandrich
Copy link
Contributor Author

Analysis of PR #14820 at 70efbcba:

Test 721 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Test 2055 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Generated by Testclutch

@dfandrich dfandrich closed this in c72dd0b Sep 7, 2024
@dfandrich dfandrich deleted the dfandrich/release-tools branch September 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants