Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: disable default OpenSSL if BearSSL, GnuTLS or Rustls is enabled #14828

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 8, 2024

Disable OpenSSL by default if any of these alterntive TLS backends were
explicitly selected.

Following the logic already in place for Schannel, Secure Transport,
mbedTLS and wolfSSL.

@bagder
Copy link
Member

bagder commented Sep 8, 2024

What about multissl builds?

@vszakats
Copy link
Member Author

vszakats commented Sep 8, 2024

This solely affects whether to enable OpenSSL by default,
when an alternate backend is explicitly selected.

For MultiSSL builds, OpenSSL needs to be explicitly enabled with
-DCURL_USE_OPENSSL=ON.

This was already the case for most TLS backends. Some were missed
from the condition controlling this. This patch syncs them up.

@vszakats vszakats changed the title cmake: disable OpenSSL if BearSSL, GnuTLS or Rustls is enabled cmake: disable default OpenSSL if BearSSL, GnuTLS or Rustls is enabled Sep 8, 2024
Follow the logic already in place for Schannel, SecureTransport,
mbedTLS and wolfSSL.
@vszakats vszakats closed this in 44f9ce0 Sep 19, 2024
@vszakats vszakats deleted the cm-openssl-def-update branch September 19, 2024 13:47
moritzbuhl pushed a commit to moritzbuhl/curl that referenced this pull request Sep 20, 2024
Disable OpenSSL by default if any of these alterntive TLS backends were
explicitly selected.

Following the logic already in place for Schannel, Secure Transport,
mbedTLS and wolfSSL.

Closes curl#14828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants