Skip to content

cmake: disable default OpenSSL if BearSSL, GnuTLS or Rustls is enabled - #14828

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:cm-openssl-def-update
Closed

cmake: disable default OpenSSL if BearSSL, GnuTLS or Rustls is enabled#14828
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:cm-openssl-def-update

Conversation

@vszakats

@vszakats vszakats commented Sep 8, 2024

Copy link
Copy Markdown
Member

Disable OpenSSL by default if any of these alterntive TLS backends were
explicitly selected.

Following the logic already in place for Schannel, Secure Transport,
mbedTLS and wolfSSL.

@bagder

bagder commented Sep 8, 2024

Copy link
Copy Markdown
Member

What about multissl builds?

@vszakats

vszakats commented Sep 8, 2024

Copy link
Copy Markdown
Member Author

This solely affects whether to enable OpenSSL by default,
when an alternate backend is explicitly selected.

For MultiSSL builds, OpenSSL needs to be explicitly enabled with
-DCURL_USE_OPENSSL=ON.

This was already the case for most TLS backends. Some were missed
from the condition controlling this. This patch syncs them up.

@vszakats vszakats changed the title cmake: disable OpenSSL if BearSSL, GnuTLS or Rustls is enabled cmake: disable default OpenSSL if BearSSL, GnuTLS or Rustls is enabled Sep 8, 2024
Follow the logic already in place for Schannel, SecureTransport,
mbedTLS and wolfSSL.
@vszakats
vszakats force-pushed the cm-openssl-def-update branch from 9aa41b6 to 3d04fbd Compare September 19, 2024 11:29
@vszakats vszakats closed this in 44f9ce0 Sep 19, 2024
@vszakats
vszakats deleted the cm-openssl-def-update branch September 19, 2024 13:47
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
Disable OpenSSL by default if any of these alterntive TLS backends were
explicitly selected.

Following the logic already in place for Schannel, Secure Transport,
mbedTLS and wolfSSL.

Closes curl#14828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants