cmake: ensure CURL_USE_OPENSSL/USE_OPENSSL_QUIC are set in sync
#14872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
CURL_USE_OPENSSL is set when USE_OPENSSL_QUIC=ONCURL_USE_OPENSSL=ON wth USE_OPENSSL_QUIC=ON
vszakats
changed the title
CURL_USE_OPENSSL=ON wth USE_OPENSSL_QUIC=ONCURL_USE_OPENSSL=ON with USE_OPENSSL_QUIC=ON
vszakats
changed the title
CURL_USE_OPENSSL=ON with USE_OPENSSL_QUIC=ONCURL_USE_OPENSSL=ON is set with USE_OPENSSL_QUIC=ON
vszakats
changed the title
CURL_USE_OPENSSL=ON is set with USE_OPENSSL_QUIC=ONCURL_USE_OPENSSL/USE_OPENSSL_QUIC are set in sync
bagder
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL must be selected (manually or by default) and detected for
USE_OPENSSL_QUIC=ONto work. This was documented before this patch,but with CMake it was possible to use
USE_OPENSSL_QUIC=ONwithoutan explicit or default
CURL_USE_OPENSSL=ON, leading to a confusedinternal state.
Fix by checking the QUIC condition early, showing a warning if enabled
without OpenSSL, and ignoring QUIC in such case.
Also: Fix casing of OpenSSL in option description.
Ref: #14866
Closes #14872