New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: stabilize test 1034 #1488

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@mkauf
Contributor

mkauf commented May 16, 2017

Pass the invalid domain name on stdin. On some systems, the test
framework cannot pass invalid UTF-8 sequences on the command line.

This fixes the remaining test error on Solaris systems, see the Autobuilds.

I have discovered that Perl's system() function may modify the contents of the string (encoding conversion). The test framework uses system() to invoke the curl tool. Maybe some Perl expert has a better idea how to fix this problem?

@dago there's only one Solaris autobuild left, it would be great if you could have a quick look at it. https://buildfarm.opencsw.org/buildbot/builders/curl-unthreaded-solaris10-i386/ has git problems, https://buildfarm.opencsw.org/buildbot/builders/curl-unthreaded-solaris11-i386 and https://buildfarm.opencsw.org/buildbot/builders/curl-unthreaded-solaris11-sparc are not triggered anymore

tests: stabilize test 1034
Pass the invalid domain name on stdin. On some systems, the test
framework cannot pass invalid UTF-8 sequences on the command line.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot May 16, 2017

@mkauf, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dfandrich and @bagder to be potential reviewers.

mention-bot commented May 16, 2017

@mkauf, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dfandrich and @bagder to be potential reviewers.

@bagder

bagder approved these changes May 17, 2017

Nice!

@mkauf mkauf closed this in 052a14e May 20, 2017

@mkauf mkauf deleted the mkauf:fix_test_1034 branch May 20, 2017

mkauf added a commit to mkauf/curl that referenced this pull request May 20, 2017

tests: stabilize test 1034
Pass the invalid domain name on stdin. On some systems, the test
framework cannot pass invalid UTF-8 sequences on the command line.

Closes curl#1488

@lock lock bot locked as resolved and limited conversation to collaborators May 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.