tests: stabilize test 1034 #1488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the invalid domain name on stdin. On some systems, the test framework cannot pass invalid UTF-8 sequences on the command line.
|
@mkauf, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dfandrich and @bagder to be potential reviewers. |
mkauf
added a commit
to mkauf/curl
that referenced
this pull request
May 20, 2017
Pass the invalid domain name on stdin. On some systems, the test framework cannot pass invalid UTF-8 sequences on the command line. Closes curl#1488
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pass the invalid domain name on stdin. On some systems, the test
framework cannot pass invalid UTF-8 sequences on the command line.
This fixes the remaining test error on Solaris systems, see the Autobuilds.
I have discovered that Perl's system() function may modify the contents of the string (encoding conversion). The test framework uses system() to invoke the curl tool. Maybe some Perl expert has a better idea how to fix this problem?
@dago there's only one Solaris autobuild left, it would be great if you could have a quick look at it. https://buildfarm.opencsw.org/buildbot/builders/curl-unthreaded-solaris10-i386/ has git problems, https://buildfarm.opencsw.org/buildbot/builders/curl-unthreaded-solaris11-i386 and https://buildfarm.opencsw.org/buildbot/builders/curl-unthreaded-solaris11-sparc are not triggered anymore