Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tidy-up: rename CURL_WINDOWS_APP to CURL_WINDOWS_UWP #14881

Closed
wants to merge 1 commit into from
Closed

tidy-up: rename CURL_WINDOWS_APP to CURL_WINDOWS_UWP #14881

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 12, 2024 •
edited
Loading

Rename internal macro to make its purpose more obvious.

After this patch grep -i uwp shows all the code related to UWP.

Ref: https://curl.se/mail/lib-2024-09/0014.html

@vszakats vszakats added Windows Windows-specific tidy-up labels Sep 12, 2024
@vszakats vszakats changed the title macro: CURL_WINDOWS_APP → CURL_WINDOWS_UWP tidy-up: rename CURL_WINDOWS_APP to CURL_WINDOWS_UWP Sep 12, 2024
MarcelRaad
MarcelRaad approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double "Windows" in there looks a bit strange to me, but I agree that having "UWP" in the identifier makes sense.

@vszakats
Copy link
Member Author

@MarcelRaad Oh indeed, it's twice Windows. But, WIN offers a tiny grepping advantage, and gives context. There is also precedent for it: _WIN32_WCE!

@vszakats vszakats closed this in bc2f72b Sep 19, 2024
@vszakats vszakats deleted the uwp-rename-macro branch September 19, 2024 17:29
moritzbuhl pushed a commit to moritzbuhl/curl that referenced this pull request Sep 20, 2024
@vszakats @moritzbuhl
tidy-up: rename CURL_WINDOWS_APP to CURL_WINDOWS_UWP
38d4800 
Rename internal macro to make its purpose more obvious.

After this patch `grep -i uwp` shows all the code related to UWP.

Ref: https://curl.se/mail/lib-2024-09/0014.html
Closes curl#14881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelRaad MarcelRaad MarcelRaad approved these changes

Assignees
No one assigned
Labels
cmdline tool tests tidy-up Windows Windows-specific
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vszakats @MarcelRaad