tidy-up: rename CURL_WINDOWS_APP to CURL_WINDOWS_UWP - #14881
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
vszakats
changed the title
CURL_WINDOWS_APP → CURL_WINDOWS_UWPCURL_WINDOWS_APP to CURL_WINDOWS_UWP
MarcelRaad
approved these changes
Sep 12, 2024
MarcelRaad
left a comment
MarcelRaad
left a comment
Member
There was a problem hiding this comment.
The double "Windows" in there looks a bit strange to me, but I agree that having "UWP" in the identifier makes sense.
Member
Author
|
@MarcelRaad Oh indeed, it's twice Windows. But, |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Rename internal macro to make its purpose more obvious. After this patch `grep -i uwp` shows all the code related to UWP. Ref: https://curl.se/mail/lib-2024-09/0014.html Closes curl#14881
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename internal macro to make its purpose more obvious.
After this patch
grep -i uwpshows all the code related to UWP.Ref: https://curl.se/mail/lib-2024-09/0014.html