cmake: fix broken dependency chain for cmdline-opts, tidy-ups - #14883
Closed
vszakats wants to merge 7 commits into
Closed
cmake: fix broken dependency chain for cmdline-opts, tidy-ups#14883vszakats wants to merge 7 commits into
vszakats wants to merge 7 commits into
Conversation
vszakats
changed the title
tool_hugehelp.c
vszakats
marked this pull request as draft
September 12, 2024 13:50
prepare fix source dependency for `tool_hugehelp.c` Also: tidy up order of a nearby dependency list. Follow-up to f03c856 curl#13047
To hint that this is _not_ a filename.
vszakats
force-pushed
the
cm-fix-manual-dependencies
branch
from
September 12, 2024 15:11
3f95d6d to
229164e
Compare
vszakats
changed the title
Also stop depending on the indirect target generate-curl.1 for tool_hugehelp.c.
vszakats
marked this pull request as ready for review
September 12, 2024 17:20
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 30, 2024
Trying to fix intermittent build failures with MSVC 2008: ``` unity_0.obj : error LNK2019: unresolved external symbol _showhelp referenced in function _tool_help unity_0.obj : error LNK2019: unresolved external symbol _hugehelp referenced in function _operate ``` https://ci.appveyor.com/project/curlorg/curl/builds/50700212/job/h3ekljnbccosej5k#L154 https://ci.appveyor.com/project/curlorg/curl/builds/50701615/job/61mkg9og1eooqli8#L155 Follow-up to 496da69 curl#14883
vszakats
added a commit
that referenced
this pull request
Sep 30, 2024
Trying to fix intermittent build failures with MSVC 2008: ``` unity_0.obj : error LNK2019: unresolved external symbol _showhelp referenced in function _tool_help unity_0.obj : error LNK2019: unresolved external symbol _hugehelp referenced in function _operate ``` https://ci.appveyor.com/project/curlorg/curl/builds/50700212/job/h3ekljnbccosej5k#L154 https://ci.appveyor.com/project/curlorg/curl/builds/50701615/job/61mkg9og1eooqli8#L155 Follow-up to 496da69 #14883 Closes #15088
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
- make `curl.1` and `curl.txt` depend on `DPAGES`. To trigger a rebuild when an individual manpage is updated. - tell CMake that the cmdline-opts command also creates `curl.txt`. - make `tool_hugehelp.c` depend on `curl.txt` (was: `curl.1`), to match what it actually uses for input. - stop using `generate-curl.1` as an indirect way to create `curl.txt` in time for `tool_hugehelp.c`. After the fixes above there is a direct depedency chain between them. - move `ASCIIPAGE` and `MANPAGE` variables to top-level, re-use them in `src` and prefix them with `CURL_` to avoid clashing with other projects. - drop double quotes from `generate-curl.1` as a hint that it is not a filename, but a target name. - src: tidy up order of dependency lists. Closes curl#14883
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Trying to fix intermittent build failures with MSVC 2008: ``` unity_0.obj : error LNK2019: unresolved external symbol _showhelp referenced in function _tool_help unity_0.obj : error LNK2019: unresolved external symbol _hugehelp referenced in function _operate ``` https://ci.appveyor.com/project/curlorg/curl/builds/50700212/job/h3ekljnbccosej5k#L154 https://ci.appveyor.com/project/curlorg/curl/builds/50701615/job/61mkg9og1eooqli8#L155 Follow-up to 496da69 curl#14883 Closes curl#15088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make
curl.1andcurl.txtdepend onDPAGES.To trigger a rebuild when an individual manpage is updated.
tell CMake that the cmdline-opts command also creates
curl.txt.make
tool_hugehelp.cdepend oncurl.txt(was:curl.1), to matchwhat it actually uses for input.
stop using
generate-curl.1as an indirect way to createcurl.txtin time for
tool_hugehelp.c. After the fixes above there is a directdepedency chain between them.
move
ASCIIPAGEandMANPAGEvariables to top-level, re-use them insrcand prefix them withCURL_to avoid clashing with otherprojects.
drop double quotes from
generate-curl.1as a hint that it is nota filename, but a target name.
src: tidy up order of dependency lists.
generate-curl.1toDEPENDSjust in case? [→ cmake: readdgenerate-curl.1dependency forsrcjust in case #15088]