checksrc: check for spaces around '?', '>' and '<' - #14921
Closed
bagder wants to merge 2 commits into
Closed
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
MarcelRaad
reviewed
Sep 16, 2024
Member
Author
|
Verifying spaces around the colons turns out to be quite difficult without catching a few false positives: they are used for switches, goto labels and bit-size indicators in struct declarations where we do not want to insist on use of space. So I'll not add that check to checksrc in this PR but I used an attempt to find a bunch of occurrences fixed here. |
... as checksrc now finds and complains about these.
bagder
force-pushed
the
bagder/checksrc-space-q
branch
from
September 18, 2024 13:31
4dfdf74 to
626579a
Compare
Member
Author
|
Buckle up! |
bagder
added a commit
that referenced
this pull request
Sep 19, 2024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
... as checksrc now finds and complains about these. Closes curl#14921
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #14912