WebSockets: make support official (non-experimental)

[bagder]

Inverts the configure/cmake options to instead provide options that disable WebSockets and have them (ws + wss) enabled by default.

[dg0yt]

Inverts the configure/cmake options to instead provide options that disable WebSockets

Not in the release notes. 😞
Also not reported as unused by CMake due to

curl/CMakeLists.txt

Lines 49 to 64 in b1ef0e1

	# Collect command-line arguments for buildinfo.txt.
	# Must reside at the top of the script to work as expected.
	get_cmake_property(_cache_vars CACHE_VARIABLES)
	unset(_cmake_args)
	foreach(_cache_var ${_cache_vars})
	get_property(_cache_var_helpstring CACHE ${_cache_var} PROPERTY HELPSTRING)
	if(_cache_var_helpstring STREQUAL "No help, variable specified on the command line.")
	get_property(_cache_var_type CACHE ${_cache_var} PROPERTY TYPE)
	if(_cache_var_type STREQUAL "UNINITIALIZED")
	set(_cache_var_type)
	else()
	set(_cache_var_type ":${_cache_var_type}")
	endif()
	set(_cmake_args "${_cmake_args} -D${_cache_var}${_cache_var_type}=\"${${_cache_var}}\"")
	endif()
	endforeach()

Another thing to patch out?

[vszakats]

Another thing to patch out?

It's useful to know how curl was built when debugging, though not supercritical to have this in buildinfo.txt (we can see the command-line now in both GHA and AppVeyor). I'll make a PR to delete it and avoid this side-effect.

Is there a better method to read the cmake command-line?

[dg0yt]

Is there a better method to read the cmake command-line?

It doesn't matter. You cannot assume to see the complete actual configuration in the command line of a single invocation. Input variables = cache variables. I can re-run cmake with no parameters, or I can change a single parameter. And then there are presets etc.

What you have is CMakeCache.txt ;-)

[vszakats]

Is there a better method to read the cmake command-line?

It doesn't matter. You cannot assume to see the complete actual configuration in the command line of a single invocation. Input variables = cache variables. I can re-run cmake with no parameters, or I can change a single parameter. And then there are presets etc.

In many cases the command-line tells enough to be useful.

What you have is CMakeCache.txt ;-)

Yes, there is also curl_dumpvars(), but for buildinfo.txt they're overkill. It was just meant to match ./configure's $ac_configure_args.

[dg0yt]

In many cases the command-line tells enough to be useful.

... assuming a single invocation of CMake for configuration purposes.