Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets: make support official (non-experimental) #14936

Closed
wants to merge 5 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 16, 2024

Inverts the configure/cmake options to instead provide options that disable WebSockets and have them (ws + wss) enabled by default.

@bagder bagder added the feature-window A merge of this requires an open feature window label Sep 16, 2024
@github-actions github-actions bot added the tests label Sep 16, 2024
@dfandrich

This comment was marked as outdated.

@bagder bagder force-pushed the bagder/welcome-ws branch 2 times, most recently from 44bb28a to 8f78651 Compare September 22, 2024 19:31
bagder added a commit that referenced this pull request Sep 22, 2024
Inverts the configure/cmake options to instead provide options that
disable WebSockets and have them (ws + wss) enabled by default.

Closes #14936
bagder added a commit that referenced this pull request Sep 25, 2024
Inverts the configure/cmake options to instead provide options that
disable WebSockets and have them (ws + wss) enabled by default.

Closes #14936
bagder added a commit that referenced this pull request Sep 26, 2024
Inverts the configure/cmake options to instead provide options that
disable WebSockets and have them (ws + wss) enabled by default.

Closes #14936
@bagder bagder closed this in d78e129 Sep 27, 2024
@bagder bagder deleted the bagder/welcome-ws branch September 27, 2024 11:23
vszakats added a commit that referenced this pull request Sep 29, 2024
- restore change lost after websockets-default update.
  Ref: 6a1dcdc #14998
- delete unused line after websockets is on by default.
  Follow-up to d78e129 #14936

Closes #15078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-window A merge of this requires an open feature window tests WebSocket
Development

Successfully merging this pull request may close these issues.

2 participants