-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Only log warnings or worse by default in smbserver #14950
Conversation
There shouldn't be anything displayed during a normal run, but only if server debugging is enabled. Also, set log_file to a magic value to disable it, otherwise impacket installs its own logger that messes with what we want. Closes #14950
Test 1451 (the SMB test) failed in the old-mingw, CM 7.3.0-x86_64 schannel U build, but I don't see how it could be related. |
Several CI jobs end with Hardly related, but rather indicates the timeout is set too strict. |
It easy to misread it as a too strict timeout, but enabling "show timestamps" The last log activity is always 5-10 minutes before these jobs get killed by This has been happening with Windows for a long time, and this Sunday it (I'm assuming here that no log activity means hung/stalled/crashed job.) edit: I had to introduces new timeouts for Linux jobs where there weren't |
Highly annoying. It also seems to happen at random places in the series of tests. |
It seems always to happen at the end. As if GH is not able to drag in the remaining output of the runtest action. |
Very annoying. I wonder if there is any watchdog or keepalive facility (combined with ps output maybe) to trace what is happening in that interim 5-10 minutes on these machines. |
In #14944 I now try to give regular log messages when the test runner is waiting on results. See, if that gives something on these hangers. |
And here we see a "hanger": https://github.com/curl/curl/actions/runs/10920448773/job/30310340171?pr=14944 Also, test 477 hangs in https://github.com/curl/curl/actions/runs/10920448773/job/30310327313?pr=14944 |
For debugging, it might sometimes help if we could connect to the runners via SSH or RDP, esp with some of the more consistent stalls that appeared in the last few days on Linux. AppVeyor CI support this, GHA runner do not, but just found that it might be possible via Tailscale: https://github.com/tailscale/github-action It's not a "one-click" feature to implement. For starters it requires a Tailscale account. Which in turn requires an OAuth account from a 'bigtech' provider (though GitHub might work for this specific use). |
@dfandrich: It's unrelated. This test has been failing since enabling impacket (enabling this test). There is a little bit more about it in the PR message: #14859 |
The test 477 issue is fixed in master since 6d0a48e |
There shouldn't be anything displayed during a normal run, but only if server debugging is enabled. Also, set log_file to a magic value to disable it, otherwise impacket installs its own logger that messes with what we want. Closes curl#14950
There shouldn't be anything displayed during a normal run, but only if
server debugging is enabled. Also, set log_file to a magic value to disable
it, otherwise impacket installs its own logger that messes with what we
want.