processhelp.pm: improve taskkill calls (Windows)
#14959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taskkill has two ways of killing a task: 1. `-pid <pid>` If `<pid>` is missing it returns 128 and outputs: ``` ERROR: The process "<pid>" not found. ``` 2. `-fi "PID eq <pid>"` If `<pid>` is missing, it returns 0 and outputs: ``` INFO: No tasks running with the specified criteria. ``` The curl runner script doesn't check the result of the call and both stdout and stderr are redirected to NUL.
vszakats
force-pushed
the
w-taskkill
branch
from
2d334a6
to
9fdc713
Compare
|
Sounds like a good plan, but haven't checked the code changes! |
vszakats
changed the title
taskkill callstaskkill calls (Windows)
moritzbuhl
pushed a commit
to moritzbuhl/curl
that referenced
this pull request
Sep 20, 2024
- drop `tasklist` call before `taskkill`.
`taskkill` offers two ways to kill a `pid`:
1. `-pid <pid>`
If `<pid>` is missing it returns 128 and outputs:
```
ERROR: The process "<pid>" not found.
```
2. `-fi "PID eq <pid>"`
If `<pid>` is missing, it returns 0 and outputs:
```
INFO: No tasks running with the specified criteria.
```
The curl runner script doesn't check the result of the call and both
stdout and stderr are redirected to NUL.
Meaning the `tasklist` calls pre-verifying if the PID exists are not
necessary and we can drop them to put less strain on the runner
environment.
- log a `taskkill` call missed earlier.
Follow-up to e53523f curl#14859
- streamline `taskkill` calls by using the `-pid` option
(was `-fi <filter-expression>`).
- make `taskkill` in `pidterm()` use `-t` to kill the process tree.
Ref: curl#11009
Closes curl#14959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop
tasklistcall beforetaskkill.taskkilloffers two ways to kill apid:-pid <pid>If
<pid>is missing it returns 128 and outputs:-fi "PID eq <pid>"If
<pid>is missing, it returns 0 and outputs:The curl runner script doesn't check the result of the call and both
stdout and stderr are redirected to NUL.
Meaning the
tasklistcalls pre-verifying if the PID exists are notnecessary and we can drop them to put less strain on the runner
environment.
log a
taskkillcall missed earlier.Follow-up to e53523f CI: move Azure jobs to GHA, fix fallouts, sshserver, runtests tweaks #14859
streamline
taskkillcalls by using the-pidoption(was
-fi <filter-expression>).make
taskkillinpidterm()use-tto kill the process tree.Ref: #11009
w/o whitespace: https://github.com/curl/curl/pull/14959/files?w=1