testrunner reliability improvements #14960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
icing
commented
Sep 18, 2024
icing
commented
- perform torture tests with '-j2' for shorter runtime
- when waiting on test results overly long, log the tests waited for and eventually log the test log directories for easier analysis what is wrong in CI jobs.
- sockfilt.c: treat the windows errno 109 (ERROR_BROKEN_PIPE) as a socket closed by the client and do not exit.
- when verifying https server, do not in addition check the http server behind it also
- when tearing down the stunnel of a non-responsive https server, tear down the http server with it
- perform torture tests with '-j2' for shorter runtime - when waiting on test results overly long, log the tests waited for and eventually log the test log directories for easier analysis what is wrong in CI jobs. - sockfilt.c: treat the windows errno 109 (ERROR_BROKEN_PIPE) as a socket closed by the client and do not exit. - when verifying https server, do not in addition check the http server behind it also - when tearing down the stunnel of a non-responsive https server, tear down the http server with it
vszakats
approved these changes
Sep 18, 2024
dfandrich
reviewed
Sep 18, 2024
| @@ -2587,15 +2587,24 @@ sub startservers { | |||
| if(stopserver('https')) { | |||
| return ("failed stopping HTTPS server with different cert", 3); | |||
| } | |||
| # also stop http server, we do not know which state it is in | |||
There was a problem hiding this comment.
The comments in stopserver() says that it already does this "given a stunnel based ssl server, also kill non-ssl underlying one". Is that not working?
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 19, 2024
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 19, 2024
Follow-up to 8ad3597 curl#14960 Closes curl#14969
moritzbuhl
pushed a commit
to moritzbuhl/curl
that referenced
this pull request
Sep 20, 2024
- perform torture tests with '-j2' for shorter runtime - when waiting on test results overly long, log the tests waited for and eventually log the test log directories for easier analysis what is wrong in CI jobs. - sockfilt.c: treat the windows errno 109 (ERROR_BROKEN_PIPE) as a socket closed by the client and do not exit. - when verifying https server, do not in addition check the http server behind it also - when tearing down the stunnel of a non-responsive https server, tear down the http server with it Closes curl#14960
moritzbuhl
pushed a commit
to moritzbuhl/curl
that referenced
this pull request
Sep 20, 2024
Follow-up to 8ad3597 curl#14960 Closes curl#14969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.