Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit1660: fix unreachable code warning in no-SSL builds #14971

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 19, 2024

Or no-HTTP, no-HSTS builds, also MSH3 builds.

CMake, VS2022, Debug, x64, no SSL, Static, Build-only:

C:\projects\curl\tests\unit\unit1660.c(46,1): error C2220: the following warning is treated as an error
C:\projects\curl\tests\unit\unit1660.c(46,1): warning C4702: unreachable code

Ref: https://ci.appveyor.com/project/curlorg/curl/builds/50531210/job/cjewvo9agavthr3o#L216

Required-by: #14922
Cherry-picked from #14772

```
C:\projects\curl\tests\unit\unit1660.c(46,1): error C2220: the following warning is treated as an error [C:\projects\curl\_bld\tests\unit\units.vcxproj]
C:\projects\curl\tests\unit\unit1660.c(46,1): warning C4702: unreachable code
```
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/50531210/job/cjewvo9agavthr3o#L216

Required-by: curl#14922
Cherry-picked from curl#14772
@vszakats vszakats changed the title unit1660: fix unreachable code warning in no-ssl builds unit1660: fix unreachable code warning in no-SSL builds Sep 19, 2024
@dfandrich
Copy link
Contributor

Analysis of PR #14971 at 6c5a4b11:

Test 3024 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Generated by Testclutch

@vszakats vszakats closed this in 3434c6b Sep 19, 2024
@vszakats vszakats deleted the unit1660-unreach branch September 19, 2024 21:06
vszakats pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants