unit1660: fix unreachable code warning in no-SSL builds - #14971
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
``` C:\projects\curl\tests\unit\unit1660.c(46,1): error C2220: the following warning is treated as an error [C:\projects\curl\_bld\tests\unit\units.vcxproj] C:\projects\curl\tests\unit\unit1660.c(46,1): warning C4702: unreachable code ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/50531210/job/cjewvo9agavthr3o#L216 Required-by: curl#14922 Cherry-picked from curl#14772
This was referenced Sep 19, 2024
vszakats
changed the title
Contributor
|
Analysis of PR #14971 at 6c5a4b11: Test 3024 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
vszakats
pushed a commit
that referenced
this pull request
Sep 20, 2024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Or no-HTTP, no-HSTS builds, also MSH3 builds. CMake, VS2022, Debug, x64, no SSL, Static, Build-only: ``` C:\projects\curl\tests\unit\unit1660.c(46,1): error C2220: the following warning is treated as an error C:\projects\curl\tests\unit\unit1660.c(46,1): warning C4702: unreachable code ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/50531210/job/cjewvo9agavthr3o#L216 Required-by: curl#14922 Cherry-picked from curl#14772 Closes curl#14971
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or no-HTTP, no-HSTS builds, also MSH3 builds.
CMake, VS2022, Debug, x64, no SSL, Static, Build-only:
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/50531210/job/cjewvo9agavthr3o#L216
Required-by: #14922
Cherry-picked from #14772