checksrc: Added checks for colon operator in ternary expressions #14990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to update test 1185 (which tests checksrc), and it now has a merge conflict (since a4703da I believe) |
gblmrn
force-pushed
the
feature/checksrc-space-c
branch
from
9dd6f7e
to
d4729f2
Compare
|
Thank you for the information. I've updated test1185 and the files that didn't pass in #15009. |
vszakats
approved these changes
Sep 22, 2024
bagder
approved these changes
Sep 25, 2024
bagder
pushed a commit
that referenced
this pull request
Sep 25, 2024
bagder
pushed a commit
that referenced
this pull request
Sep 25, 2024
|
Thanks! |
|
No problem, glad to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to provide a check for colon operators in ternary expressions.
Sadly, the current version does work only for ternary expressions that are written in one line.