Closed
Conversation
cmake: pytest depend on http/clients only
Contributor
|
Analysis of PR #15034 at 23b00f72: Test 445 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
icing
approved these changes
Sep 25, 2024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
It enables running pytests in cmake jobs, regardless of underlying build tool choice (= makes it work with ninja.) Also: - drop pytest logic launching `make` and exiting in case of failure. Maybe there is a better way and keep this functionality somehow, bind it to a command-line option? make it fail softly? - GHA/linux: invoke pytest via the build, not directly. - autotools: add missing dummy runtests targets when cross-compiling. Closes curl#15034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It enables running pytests in cmake jobs, regardless of underlying build
tool choice (= makes it work with ninja.)
Also:
drop pytest logic launching
makeand exiting in case of failure.Maybe there is a better way and keep this functionality somehow, bind
it to a command-line option? make it fail softly?
GHA/linux: invoke pytest via the build, not directly.
autotools: add missing dummy runtests targets when cross-compiling.