test: add native features to check for, to reduce need for prechecks#15039
Closed
test: add native features to check for, to reduce need for prechecks#15039
Conversation
It can now be required easily in <features> instead of having perl code in a <precheck>.
This is the %CLIENT6IP variable - but without outmost brackets since some commmand lines need the address without the brackets. With this variable we can run three more tests without prechecks.
To avoid having to use <precheck> for tests that require UTF-8 support.
Contributor
|
Analysis of PR #15039 at 8818eed0: Test 1035 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
bagder
added a commit
that referenced
this pull request
Sep 26, 2024
This is the %CLIENT6IP variable - but without outmost brackets since some commmand lines need the address without the brackets. With this variable we can run three more tests without prechecks. Closes #15039
bagder
added a commit
that referenced
this pull request
Sep 26, 2024
To avoid having to use <precheck> for tests that require UTF-8 support. Closes #15039
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
It can now be required easily in <features> instead of having perl code in a <precheck>. Closes curl#15039
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
This is the %CLIENT6IP variable - but without outmost brackets since some commmand lines need the address without the brackets. With this variable we can run three more tests without prechecks. Closes curl#15039
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
To avoid having to use <precheck> for tests that require UTF-8 support. Closes curl#15039
1 task
vszakats
added a commit
that referenced
this pull request
Jul 23, 2025
- runtests: fix `codeset-utf8` feature detection. Before this patch it detected if the calling environment had UTF-8 enabled. If not, UTF-8 tests were all skipped. After this patch, it detects if UTF-8 is supported by the calling environment regardless of what's currently enabled. Follow-up to 0b70b23 #15039 - GHA/linux: sync `codeset-test` to also reset `LC_CTYPE` and `LC_NUMBER`. To give it more spin. Follow-up to c221c0e #17938 - GHA/macos: fix to actually enable `codeset-test`. Also set `LC_ALL`, which seems necessary to trigger issues. Follow-up to c221c0e #17938 - tests/data: replace `LC_CTYPE` env with `LC_ALL` in all tests requiring a locale. Also to avoid potential issues with a blank or unset `LC_ALL`, as seen earlier. And to ensure that the override works on all platforms (as tested in CI.) Slight downside is that this now resets the language/culture to `C`. Ref: b4c9982 #4743 Ref: 23208e3 #4738 - replace `en_US.UTF-8` with `C.UTF-8` to be language/culture-agnostic. - TEST-SUITE.md: drop `UTF-8` as a requirement for tests. Tests shall work (or least be skipped) without UTF-8 support. Tests requiring UTF-8 locale: 165, 962, 963, 964, 965, 966, 967, 1448, 1560, 2046, 2047 Tests requiring UTF-8 locale, but passing without one anyway: 955, 956, 957, 958, 959, 960, 961, 968, 1034, 1035 Spec 1997: https://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html Spec 2008: https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html Ref: c221c0e #17938 Ref: 7cf8414 Ref: 4c140a5 Ref: 28faaac #2436 Ref: ecd1d02 Closes #17988
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.