tool_doswin: simplify; remove unused options and strncpy calls #15047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
SANITIZE_ALLOW_TRUNCATE and SANITIZE_ALLOW_COLONS were never used by code, thus only making the code complicated for no good use. Since nothing should truncate, using strncpy() is wrong. Two cases of malloc + copy replaced with proper strdup() calls. Fixup unit test 1604 accordingly. Closes #15047
bagder
force-pushed
the
bagder/doswin-simplify
branch
from
4045f15
to
f383a17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SANITIZE_ALLOW_TRUNCATE and SANITIZE_ALLOW_COLONS were never used by code, thus only making the code complicated for no good use.
Since nothing should truncate, using strncpy() is wrong.
Two cases of malloc + copy replaced with proper strdup() calls.
Fixup unit test 1604 accordingly.