http-proxy: only attempt FTP over HTTP proxy#1505
Conversation
|
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @yangtse and @yirkha to be potential reviewers. |
|
all other non-HTTP schemes |
... all other non-HTTP protocol schemes are now defaulting to "tunnel trough" mode if a HTTP proxy is specified. In reality there are no HTTP proxies out there that allow those other schemes. Assisted-by: Ray Satiro, Michael Kaufmann
bagder
force-pushed
the
bagder/non-http-no-http-proxy
branch
from
7906896 to
8e34b02
Compare
bagder
added
connecting & proxies
HTTP
feature-window
|
Due to the slight change in behavior, I figured I'll wait with merging this until the next feature-window opens. |
mkauf
left a comment
mkauf
left a comment
There was a problem hiding this comment.
Thanks, this really simplifies the proxy code :-)
| #define PROTOPT_STREAM (1<<9) /* a protocol with individual logical streams */ | ||
| #define PROTOPT_URLOPTIONS (1<<10) /* allow options part in the userinfo field | ||
| of the URL */ | ||
| #define PROTOPT_HTTP_PROXY (1<<11) /* allow over a HTTP proxy */ |
There was a problem hiding this comment.
I think we should explain that this flag is not intended for HTTP itself, and that the only difference is whether tunneling will be enabled automatically.
Maybe "HTTP proxies may know this protocol and act as a gateway" ?
There was a problem hiding this comment.
Thanks, that's a good point. I'll add something in that style.
There was a problem hiding this comment.
why don't we just put it directly in the flag, PROTOPT_ALLOW_HTTP_PROXY or something
There was a problem hiding this comment.
PROTOPT_PROXY_AS_HTTP is another one
There was a problem hiding this comment.
I like the latter suggestion more. PROTOPT_PROXY_AS_HTTP it shall be, thanks!
4 participants
... all other protocol schemes are now defaulting to "tunnel trough"
mode if a HTTP proxy is specified. In reality there are no HTTP proxies
out there that allow those other schemes.
ping @jay and @mkauf
Assisted-by: Ray Satiro, Michael Kaufmann