test504, fix handling on pending connect#15054
Closed
icing wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
Test expected a connect to a port no one is listening to immediately fail. But Windows has its internal retry logic that may fail this. As fix, multi_perform()/multi_wait() until transfer is done.
Contributor
|
Analysis of PR #15054 at 8f9208bf: Test 1035 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
bagder
approved these changes
Sep 26, 2024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Test expected a connect to a port no one is listening to immediately fail. But Windows has its internal retry logic that may fail this. As fix, multi_perform()/multi_wait() until transfer is done. Closes curl#15054
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test expected a connect to a port no one is listening to immediately fail. But Windows has its internal retry logic that may fail this.
As fix, multi_perform()/multi_wait() until transfer is done.