Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test190: replace %FTPTIME2 with a fixed value #15056

Closed
wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Sep 26, 2024

The variable FTPTIME2 may, on a loaded test server, become so large that the timeout does not happen before the fixed 60 seconds the server waits.

The variable FTPTIME2 may, on a loaded test server, become so
large that the timeout does not happen before the fixed 60 seconds
the server waits.
@github-actions github-actions bot added the tests label Sep 26, 2024
@icing icing requested a review from bagder September 26, 2024 13:03
@dfandrich
Copy link
Contributor

Analysis of PR #15056 at 62084b9d:

Test 1035 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Test 1562 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Generated by Testclutch

@bagder
Copy link
Member

bagder commented Sep 26, 2024

FTPTIME2 is used in eight other tests. Is it worth doing this replace in all of them?

bagder added a commit that referenced this pull request Sep 26, 2024
@icing
Copy link
Contributor Author

icing commented Sep 26, 2024

FTPTIME2 is used in eight other tests. Is it worth doing this replace in all of them?

I only fixed where I saw failures.

bagder added a commit that referenced this pull request Sep 26, 2024
@bagder bagder closed this in ef400f4 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants