tests: use '-4' where needed - #15060
Closed
icing wants to merge 1 commit into
Closed
Conversation
Our test servers run either on ipv4 *or* on ipv6, as requested. A test case using 'localhost' or '*.local' in the url needs to run with the specific version of the server started. Otherwise, curl's "happy eyeball"ing will connect to another server that may be running due to parallel testing or for some other reasons. Note that port reuse here depends on the OS strategy and it seems netbsd is especially likely to hit this.
Contributor
|
Analysis of PR #15060 at 3d27e498: Test 1035 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
bagder
approved these changes
Sep 26, 2024
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Our test servers run either on ipv4 *or* on ipv6, as requested. A test case using 'localhost' or '*.local' in the url needs to run with the specific version of the server started. Otherwise, curl's "happy eyeball"ing will connect to another server that may be running due to parallel testing or for some other reasons. Note that port reuse here depends on the OS strategy and it seems netbsd is especially likely to hit this. Closes curl#15060
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our test servers run either on ipv4 or on ipv6, as requested. A test case using 'localhost' or '*.local' in the url needs to run with the specific version of the server started.
Otherwise, curl's "happy eyeball"ing will connect to another server that may be running due to parallel testing or for some other reasons.
Note that port reuse here depends on the OS strategy and it seems netbsd is especially likely to hit this.