multi: avoid reading whole struct pointer from pointer - #15063
Closed
bagder wants to merge 1 commit into
Closed
Conversation
The proper alignment is not guaranteed. This now uses only the first and last byte in the key since they are the ones likely to change most (one of them, depending on CPU endian) and the hash is tiny anyway.
bagder
changed the title
Contributor
|
Analysis of PR #15063 at 7afd6417: Test 2405 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Test 1035 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
Member
|
if the keylen is greater than the size of a Curl_easy then wouldn't it be out of bounds? |
Member
Author
|
They keys are |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
The proper alignment is not guaranteed. This function now instead uses only the first and last byte of the key since they are the ones likely to change most (one of them, depending on CPU endian) and the hash is tiny anyway. Closes curl#15063
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proper alignment is not guaranteed. This now uses only the first and last byte in the key since they are the ones likely to change most (one of them, depending on CPU endian) and the hash is tiny anyway.