tests: replace %PWD with %FILE_PWD for file:// - #15090
Closed
vszakats wants to merge 13 commits into
Closed
Conversation
…rong for Win32? Before this PR on Windows: runclient: msys: Executing: '../src/curl.exe -q --output log/7/curl1145.out --include --trace-ascii log/7/trace1145 --trace-config all --trace-time file://bad-hostD:/a/curl/curl/bld/tests//log/7/test1145.txt > log/7/stdout1145 2> log/7/stderr1145' https://github.com/curl/curl/actions/runs/11086916586/job/30805027531#step:25:9297 This PR before this patch after switch PWD to FILE_PWD: runclient: msys: Executing: '../src/curl.exe -q --output log/7/curl1145.out --include --trace-ascii log/7/trace1145 --trace-config all --trace-time file://bad-host/D:/a/curl/curl/bld/tests/log/7/test1145.txt > log/7/stdout1145 2> log/7/stderr1145' Fails due to: curl returned 37, when expecting 3 curl: (37) Couldn't open file //bad-host/D:/a/curl/curl/bld/tests/log/7/test1145.txt https://github.com/curl/curl/actions/runs/11092904035/job/30818523915#step:25:9854 I'm not sure where the bug is in this case.
vszakats
changed the title
PWD with FILE_PWD, fix it for native Win32 PerlPWD with FILE_PWD for file://
vszakats
marked this pull request as draft
September 30, 2024 14:23
vszakats
changed the title
PWD with FILE_PWD for file://%PWD with %FILE_PWD for file://
vszakats
marked this pull request as ready for review
September 30, 2024 18:51
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Before this patch not all tests used `%FILE_PWD` with the `file://` protocol. Keep `%PWD` for test1145, to keep it fail on Windows like the test expects. Cherry-picked from curl#14949 Closes curl#15090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch not all tests used
%FILE_PWDwith thefile://protocol.
Keep
%PWDfor test1145, to keep it fail on Windows like the testexpects.
Cherry-picked from #14949
Except for test1145, where
FILE_PWDbreaks it for Win32. I'm unsure ifthis is a problem with the test, with the code or with the expected
result on native Windows.
Before/after this PR on Windows:
https://github.com/curl/curl/actions/runs/11086916586/job/30805027531#step:25:9297
When replacing
%PWDwith%FILE_PWDthe URL becomes correct, butthe failure isn't the one expected by the test:
Fails due to:
https://github.com/curl/curl/actions/runs/11092904035/job/30818523915#step:25:9854
I'm guessing this is a problem with the test, because on native Windows
that sort of URL isn't a malformed one, just a normal one that's not
hitting any file. To trigger a malformed one, besides
bad-hostit alsoneeds a bad
%PWD, which was done by accident before this patch.