Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufq unwrite fix #15136

Closed
wants to merge 5 commits into from
Closed

bufq unwrite fix #15136

wants to merge 5 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Oct 3, 2024

Curl_bufq_unwrite() used the head instead of the tail chunk to shrink the bufq's content. Fix this and add test case that checks correct behaviour.

Affects only the WebSocket protocol, not used anywhere else.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonus points is handed out if you add some blurb about this function to docs/internals/BUFQ.md ...

@icing
Copy link
Contributor Author

icing commented Oct 3, 2024

Bonus points is handed out if you add some blurb about this function to docs/internals/BUFQ.md ...

Added.

`Curl_bufq_unwrite()` used the head instead of the tail chunk to
shrink the bufq's content. Fix this and add test case that checks
correct behaviour.
@github-actions github-actions bot added the CI Continuous Integration label Oct 3, 2024
@bagder
Copy link
Member

bagder commented Oct 3, 2024

🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants