bufq unwrite fix - #15136
Closed
icing wants to merge 5 commits into
Closed
Conversation
bagder
approved these changes
Oct 3, 2024
bagder
left a comment
bagder
left a comment
Member
There was a problem hiding this comment.
Bonus points is handed out if you add some blurb about this function to docs/internals/BUFQ.md ...
Contributor
Author
Added. |
`Curl_bufq_unwrite()` used the head instead of the tail chunk to shrink the bufq's content. Fix this and add test case that checks correct behaviour.
icing
force-pushed
the
bufq-unwrite-fix
branch
from
October 3, 2024 09:56
261a3a7 to
511730b
Compare
Member
|
🥇 |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
`Curl_bufq_unwrite()` used the head instead of the tail chunk to shrink the bufq's content. Fix this and add test case that checks correct behaviour. Amended test 2601 accordingly. Reported-by: Chris Stubbs Closes curl#15136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curl_bufq_unwrite()used the head instead of the tail chunk to shrink the bufq's content. Fix this and add test case that checks correct behaviour.Affects only the WebSocket protocol, not used anywhere else.