openssl quic, populate x509 store before handshake - #15137
Closed
icing wants to merge 1 commit into
Closed
Conversation
bagder
approved these changes
Oct 3, 2024
Contributor
|
Analysis of PR #15137 at 22bbf49e: Test http/test_07_upload.py::TestUpload::test_07_42a_upload_disconnect[0-h2] failed, which has NOT been flaky recently, so there could be a real issue in the PR. Test 1450 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
Since OpenSSL does its own send/recv internally, we may miss the moment to populate the x509 store right before the server response. Do it instead before we start the handshake, at the loss of the time to set this up.
icing
force-pushed
the
ossl-quic-store-init
branch
from
October 3, 2024 10:07
22bbf49 to
d308675
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Since OpenSSL does its own send/recv internally, we may miss the moment to populate the x509 store right before the server response. Do it instead before we start the handshake, at the loss of the time to set this up. Closes curl#15137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since OpenSSL does its own send/recv internally, we may miss the moment to populate the x509 store right before the server response. Do it instead before we start the handshake, at the loss of the time to set this up.
This should fix the spurious CI failures in openssl-quic.