asyn-ares: remove typecast, fix expire - #15145
Closed
bagder wants to merge 1 commit into
Closed
Conversation
- Use the appropriate variable type for the curlx_tvtoms() return code: timediff_t and remove the typecast. - Simplify the function and avoid the odd expire adjustment that probably is a rest from ancient days when the expire function did not handle zero millisecond timeouts.
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
- Use the appropriate variable type for the curlx_tvtoms() return code: timediff_t and remove the typecast. - Simplify the function and avoid the odd expire adjustment that probably is a rest from ancient days when the expire function did not handle zero millisecond timeouts. Closes curl#15145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the appropriate variable type for the curlx_tvtoms() return code: timediff_t and remove the typecast.
Simplify the function and avoid the odd expire adjustment that probably is a rest from ancient days when the expire function did not handle zero millisecond timeouts.