configure: drop duplicate feature checks for poll(), if_nametoindex() - #15170
Closed
vszakats wants to merge 3 commits into
Closed
configure: drop duplicate feature checks for poll(), if_nametoindex()#15170vszakats wants to merge 3 commits into
poll(), if_nametoindex()#15170vszakats wants to merge 3 commits into
Conversation
bagder
approved these changes
Oct 7, 2024
bagder
left a comment
bagder
left a comment
Member
There was a problem hiding this comment.
I think it makes sense to use the much simpler checks as long as we don't know any specific reasons why we need the "deeper" ones. And I don't know of any such reasons for these functions.
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
…x()` Before this patch they were detected via manual methods, then with `AC_CHECK_FUNCS()`. Delete the manual checks and keep the latter. Also delete `CURL_INCLUDES_POLL()` which is no longer used after the above. Closes curl#15170
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch they were detected via manual methods, then with
AC_CHECK_FUNCS().Delete the manual checks and keep the latter.
Also delete
CURL_INCLUDES_POLL()which is no longer used afterthe above.
Let me know if there is/was a reason for the duplicate checks, or if
it'd be better to keep the manual checks instead.