Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: drop duplicate feature checks for poll(), if_nametoindex() #15170

Closed
wants to merge 3 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 6, 2024

Before this patch they were detected via manual methods, then with
AC_CHECK_FUNCS().

Delete the manual checks and keep the latter.

Also delete CURL_INCLUDES_POLL() which is no longer used after
the above.


Let me know if there is/was a reason for the duplicate checks, or if
it'd be better to keep the manual checks instead.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to use the much simpler checks as long as we don't know any specific reasons why we need the "deeper" ones. And I don't know of any such reasons for these functions.

@vszakats vszakats closed this in 2d1959d Oct 7, 2024
@vszakats vszakats deleted the configure-drop-dupe-detections branch October 7, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants