cmake: detect HAVE_NETINET_IN6_H, HAVE_CLOSESOCKET_CAMEL, HAVE_PROTO_BSDSOCKET_H - #15172
Closed
vszakats wants to merge 3 commits into
Closed
cmake: detect HAVE_NETINET_IN6_H, HAVE_CLOSESOCKET_CAMEL, HAVE_PROTO_BSDSOCKET_H#15172vszakats wants to merge 3 commits into
HAVE_NETINET_IN6_H, HAVE_CLOSESOCKET_CAMEL, HAVE_PROTO_BSDSOCKET_H#15172vszakats wants to merge 3 commits into
Conversation
vszakats
force-pushed
the
cm-missing-detections
branch
from
October 7, 2024 02:18
de93c46 to
c2364c5
Compare
Contributor
|
Analysis of PR #15172 at c2364c58: Test 504 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
do not add socket.h committed to configure in 37eba37 to detect socket and closesocket, but then this header is nowhere used from the code itself, suggesting this was unnecessary. Let's not add this to cmake. It probably could be deleted from configure. limit HAVE_CLOSESOCKET_CAMEL to AmigaOS limit HAVE_PROTO_BSDSOCKET_H to AmigaOS
vszakats
force-pushed
the
cm-missing-detections
branch
from
October 7, 2024 10:36
c2364c5 to
ccb4007
Compare
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
…ROTO_BSDSOCKET_H` To sync with `./configure`. - `HAVE_NETINET_IN6_H` is needed by HPE NonStop NSE and NSX systems. Follow-up to 76ebd54 curl#2155 - `HAVE_CLOSESOCKET_CAMEL`, `HAVE_PROTO_BSDSOCKET_H` are for AmigaOS. (Note: `./configure` tries to detect these for all targets, cmake does it only for AmigaOS, to not inflate configure time.) Closes curl#15172
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To sync with
./configure.HAVE_NETINET_IN6_Hisneeded by HPE NonStop NSE and NSX systems.
Follow-up to 76ebd54 Support for HPE NonStop NSE and NSX systems for IPv6 compatibility via configure #2155
HAVE_CLOSESOCKET_CAMEL,HAVE_PROTO_BSDSOCKET_Hare for AmigaOS.
(Note:
./configuretries to detect these for all targets, cmake doesit only for AmigaOS, to not inflate configure time.)