Skip to content

configure: drop unused bare socket.h detection - #15173

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:drop-socket-h
Closed

configure: drop unused bare socket.h detection#15173
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:drop-socket-h

Conversation

@vszakats

@vszakats vszakats commented Oct 7, 2024

Copy link
Copy Markdown
Member

Added in 37eba37 (2009-06-17) to help
detecting socket functions.

But, this socket.h isn't used in the source code since
90dd1fc #8288 (2022-01-16).

Added in 37eba37 (2009-06-17) to help
detecting socket functions.

But, this `socket.h` isn't used in the source code since
90dd1fc curl#8288 (2022-01-16).
@dfandrich

Copy link
Copy Markdown
Contributor

Analysis of PR #15173 at ffa96277:

Test 1450 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Test 1632 failed, which has NOT been flaky recently, so there could be a real issue in the PR.

Generated by Testclutch

@vszakats vszakats closed this in 86d5c26 Oct 7, 2024
@vszakats
vszakats deleted the drop-socket-h branch October 7, 2024 10:33
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
Added in 37eba37 (2009-06-17) to help
detecting socket functions.

But, this `socket.h` isn't used in the source code since
90dd1fc curl#8288 (2022-01-16).

Closes curl#15173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants