doc: cli-option --json is an alias of --data-binary - #15197
Closed
sivizius wants to merge 1 commit into
Closed
Conversation
bagder
approved these changes
Oct 8, 2024
Member
|
Thanks! |
ftnext
added a commit
to ftnext/everything-curl
that referenced
this pull request
Feb 22, 2025
bagder
pushed a commit
to curl/everything-curl
that referenced
this pull request
Feb 22, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to https://github.com/curl/curl/blob/master/src/tool_getparam.c#L879-L880,
--jsonis actually an alias for--data-binary, not--data. Assuming the code is as intended, the documentation should reflect that.I encountered this by switching from
-h 'Content-Type: application/json' -d @invalid.jsonto--json @invalid.jsonin a test, that expected a parsing-error, which contains some information about the line and column. However, due to effectively switching to--data-binary, the line and column were off and the test failed.This PR does not change the behaviour of this test, but correctly informs the user about the actual behaviour of
--json.