tool_getparam: replace two uses of strncpy(), ban strncpy - #15212
Closed
bagder wants to merge 1 commit into
Closed
Conversation
strncpy() is rarely the right choice
Contributor
|
Analysis of PR #15212 at 143af1a8: Test 303 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Test 1631 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Test 1632 failed, which has NOT been flaky recently, so there could be a real issue in the PR. Generated by Testclutch |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
strncpy() is rarely the right choice Closes curl#15212
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strncpy() is rarely the right choice