Skip to content

mbedTLS, fix handling of TLSv1.3 sessions - #15245

Closed
icing wants to merge 5 commits into
curl:masterfrom
icing:mbedtls-1.3-session-fix
Closed

mbedTLS, fix handling of TLSv1.3 sessions#15245
icing wants to merge 5 commits into
curl:masterfrom
icing:mbedtls-1.3-session-fix

Conversation

@icing

@icing icing commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

For TLSv1.3, if supported, observer special return code to retrieve newly arrived session from mbedTLS.

Adjust test expectations now that TLSv1.3 session resumption works in mbedTLS >= 3.6.0.

Based on #14135 by @ad-chaos

@icing
icing marked this pull request as ready for review October 10, 2024 10:49
@github-actions github-actions Bot added the tests label Oct 10, 2024
@icing icing added the TLS label Oct 10, 2024
@icing
icing requested a review from bagder October 10, 2024 11:15
@bagder

bagder commented Oct 11, 2024

Copy link
Copy Markdown
Member

merge conflict

icing added 2 commits October 12, 2024 11:10
For TLSv1.3, if supported, observer special return code to retrieve
newly arrived session from mbedTLS.

Adjust test expectations now that TLSv1.3 session resumption works in mbedTLS >= 3.6.0.

Based on curl#14135 by @ad-chaos
@icing
icing force-pushed the mbedtls-1.3-session-fix branch from 6ecd80b to 5d1eeb3 Compare October 12, 2024 09:18
@icing

icing commented Oct 12, 2024

Copy link
Copy Markdown
Contributor Author

merge conflict

Resolved.

@dfandrich

Copy link
Copy Markdown
Contributor

Analysis of PR #15245 at ad9cf528:

Test http/test_17_ssl_use.py::TestSSLUse::test_17_02_sslinfo_reconnect[1.3] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 3455d36 Oct 13, 2024
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
For TLSv1.3, if supported, observer special return code to retrieve
newly arrived session from mbedTLS.

Adjust test expectations now that TLSv1.3 session resumption works in
mbedTLS >= 3.6.0.

Based on curl#14135 by @ad-chaos
Closes curl#15245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants