cmake: stop adding dependency headers to global CMAKE_REQUIRED_INCLUDES - #15252
Closed
vszakats wants to merge 1 commit into
Closed
cmake: stop adding dependency headers to global CMAKE_REQUIRED_INCLUDES#15252vszakats wants to merge 1 commit into
CMAKE_REQUIRED_INCLUDES#15252vszakats wants to merge 1 commit into
Conversation
…DES` Cherry-picked from curl#15157
Member
Author
|
Turns out there is a side-effect of this patch: On the other hand this job demonstrates that CMake's LDAP was never up to par with configure. OpenLDAP should be detected here, both libs and headers. This is a task for a future effort and PR. |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
…DES` It was done for `zlib`, `brotli`, `libpsl`, `libssh2`, `wolfssh` (a copy-paste case for `wolfssh`). Feature detections should not rely by default on dependency headers. There is no evidence they do now. If it becomes necessary, headers should added for the duration of the feature check. Ref: 118977f Cherry-picked from curl#15157 Closes curl#15252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was done for
zlib,brotli,libpsl,libssh2,wolfssh(a copy-paste case for
wolfssh).Feature detections should not rely by default on dependency headers.
There is no evidence they do now. If it becomes necessary, headers
should added for the duration of the feature check.
Ref: 118977f
Cherry-picked from #15157