Skip to content

winbuild: add initial wolfSSL support - #15264

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:wb-wolfssl
Closed

winbuild: add initial wolfSSL support#15264
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:wb-wolfssl

Conversation

@vszakats

@vszakats vszakats commented Oct 11, 2024

Copy link
Copy Markdown
Member

@vszakats vszakats added build TLS Windows Windows-specific labels Oct 11, 2024
@vszakats
vszakats requested a review from jay October 12, 2024 06:41
@vszakats

Copy link
Copy Markdown
Member Author

@jay: I don't mean to test it with wolfSSL. It probably "should" work, or if not, someone using it can report any issue. But I have no way to run this script to verify if I made a silly mistake that breaks it.

@vszakats

vszakats commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

But, according to AppVeyor CI, there is no trivial typo in this PR and existing builds continue to work: https://ci.appveyor.com/project/curlorg/curl/builds/50776650

@jay

jay commented Oct 14, 2024

Copy link
Copy Markdown
Member

It should be confirmed working before it is added, that said the code looks ok

@vszakats

vszakats commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

I'd say it's good as an initial implementation and straighforward enough that it "just works". The same change has been added and tested earlier in Makefile.mk. It's basically a copy-paste change with include, lib and wolfssl.lib set compared to e.g. mbedTLS.

One setting that may or may not be necessary is -DSIZEOF_LONG_LONG=8. It seemed necessary a few years ago to avoid a build issue within a wolfSSL header. Also with CMake, but our CI builds never needed that.
curl/curl-for-win@04f3a9c

Chances are good this setting is no longer needed. In any case if it's an issue, someone will likely report it.

@vszakats vszakats changed the title winbuild: add wolfSSL support winbuild: add inital wolfSSL support Oct 14, 2024
@vszakats vszakats changed the title winbuild: add inital wolfSSL support winbuild: add initial wolfSSL support Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build TLS Windows Windows-specific

Development

Successfully merging this pull request may close these issues.

3 participants