Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use CMAKE_REQUIRED_LINK_DIRECTORIES #15280

Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 12, 2024

Use CMAKE_REQUIRED_LINK_DIRECTORIES with CMake 3.31.0 and upper,
in local macro curl_required_libpaths().

Kitware/CMake@9e95bd4
https://gitlab.kitware.com/cmake/cmake/-/commit/9e95bd49f278cd2a05caf21fd624a41e4bfaba60
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9795
https://cmake.org/cmake/help/v3.31/module/CheckSymbolExists.html

Tested OK with cmake 3.31.0-rc1.

Follow-up to 01a8157 #15271
Follow-up to 7bab201 #15193


  • do not merge before the CMake 3.31.0 release.

w/o whitespace: https://github.com/curl/curl/pull/15280/files?w=1

@vszakats vszakats added cmake feature-window A merge of this requires an open feature window labels Oct 12, 2024
@github-actions github-actions bot added the build label Oct 12, 2024
@vszakats vszakats removed the on-hold label Nov 11, 2024
@vszakats vszakats force-pushed the cm-use-CMAKE_REQUIRED_LINK_OPTIONS branch from d96ecd7 to 98565a6 Compare December 16, 2024 17:14
@vszakats vszakats closed this in 3dbd436 Dec 16, 2024
@vszakats vszakats deleted the cm-use-CMAKE_REQUIRED_LINK_OPTIONS branch December 16, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build cmake feature-window A merge of this requires an open feature window
Development

Successfully merging this pull request may close these issues.

1 participant