libssh2: put the readdir buffers into struct - #15285
Closed
bagder wants to merge 2 commits into
Closed
Conversation
bagder
force-pushed
the
bagder/readdir-buffers
branch
from
October 14, 2024 06:10
7a62a75 to
9545954
Compare
... instead of separate malloc() calls: - removes two mallocs (and associated error handling paths) - makes cleanup easier Also reduce maximum SFTP file path lengths to 1024 bytes universally everywhere. Using the system's own MAX_PATH did not make sense since this is mostly about getting a remote file name. Closes #15285
bagder
force-pushed
the
bagder/readdir-buffers
branch
from
October 15, 2024 22:03
9545954 to
99dbbc0
Compare
Avoids having to use a big stack buffer for this.
bagder
added a commit
that referenced
this pull request
Oct 16, 2024
Avoids having to use a big stack buffer for this. Closes #15285
Member
|
With this patch, a vcpkg jobs using libssh fails with: https://github.com/curl/curl/actions/runs/11366969951/job/31618594231?pr=15307#step:9:28 |
bagder
added a commit
that referenced
this pull request
Oct 16, 2024
Follow-up to facf59c Reported-by: Viktor Szakats Bug: #15285 (comment)
bagder
added a commit
that referenced
this pull request
Oct 16, 2024
Follow-up to facf59c Reported-by: Viktor Szakats Bug: #15285 (comment) Closes #15309
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
... instead of separate malloc() calls: - removes two mallocs (and associated error handling paths) - makes cleanup easier Also reduce maximum SFTP file path lengths to 1024 bytes universally everywhere. Using the system's own MAX_PATH did not make sense since this is mostly about getting a remote file name. Closes curl#15285
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Avoids having to use a big stack buffer for this. Closes curl#15285
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Follow-up to facf59c Reported-by: Viktor Szakats Bug: curl#15285 (comment) Closes curl#15309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... instead of separate malloc() calls:
Also reduce maximum SFTP file path lengths to 1024 bytes universally everywhere. Using the system's own MAX_PATH did not make sense since this is mostly about getting a remote file name.