Skip to content

vquic: fix compiler warning with gcc + MUSL - #15303

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:warns-1016
Closed

vquic: fix compiler warning with gcc + MUSL#15303
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:warns-1016

Conversation

@vszakats

Copy link
Copy Markdown
Member
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c: In function 'msghdr_get_udp_gro':
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:344: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  344 | #pragma clang diagnostic push
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:345: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  345 | #pragma clang diagnostic ignored "-Wsign-compare"
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:346: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  346 | #pragma clang diagnostic ignored "-Wcast-align"
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:350: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  350 | #pragma clang diagnostic pop
      |

https://github.com/curl/curl-for-win/actions/runs/11356281008/job/31587180874#step:3:9534

Follow-up to a571afc #14012

```
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c: In function 'msghdr_get_udp_gro':
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:344: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  344 | #pragma clang diagnostic push
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:345: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  345 | #pragma clang diagnostic ignored "-Wsign-compare"
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:346: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  346 | #pragma clang diagnostic ignored "-Wcast-align"
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:350: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  350 | #pragma clang diagnostic pop
      |
```
https://github.com/curl/curl-for-win/actions/runs/11356281008/job/31587180874#step:3:9534

Follow-up to a571afc curl#14012
@vszakats vszakats added build HTTP/3 h3 or quic related labels Oct 16, 2024
@vszakats vszakats changed the title vquic: fix compiler warning with gcc and MUSL vquic: fix compiler warning with gcc + MUSL Oct 16, 2024
@dfandrich

Copy link
Copy Markdown
Contributor

Analysis of PR #15303 at 6ef0e21b:

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-0--2] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-0--1] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-0-0] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-1--2] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-1--1] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-1-0] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-2--2] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

There are more failures, but that's enough from Gha.

Generated by Testclutch

@vszakats vszakats closed this in 7fbcf4b Oct 16, 2024
@vszakats
vszakats deleted the warns-1016 branch October 16, 2024 10:09
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
```
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c: In function 'msghdr_get_udp_gro':
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:344: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  344 | #pragma clang diagnostic push
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:345: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  345 | #pragma clang diagnostic ignored "-Wsign-compare"
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:346: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  346 | #pragma clang diagnostic ignored "-Wcast-align"
      |
/Users/runner/work/curl-for-win/curl-for-win/curl/lib/vquic/vquic.c:350: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
  350 | #pragma clang diagnostic pop
      |
```
https://github.com/curl/curl-for-win/actions/runs/11356281008/job/31587180874#step:3:9534

Follow-up to a571afc curl#14012
Closes curl#15303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

3 participants