Skip to content

src: guard for double declaration of curl_ca_embed in unity builds - #15307

Closed
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:src-double-declare-ca-embed
Closed

src: guard for double declaration of curl_ca_embed in unity builds#15307
vszakats wants to merge 2 commits into
curl:masterfrom
vszakats:src-double-declare-ca-embed

Conversation

@vszakats

@vszakats vszakats commented Oct 16, 2024

Copy link
Copy Markdown
Member

Seen with curl-for-win linux-musl-from-mac build with gcc 9.2.0.

n file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:136:
/Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/tool_ca_embed.c:4:28: warning: redundant redeclaration of 'curl_ca_embed' [-Wredundant-decls]
    4 | extern const unsigned char curl_ca_embed[];
      |                            ^~~~~~~~~~~~~
In file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:88:
/Users/runner/work/curl-for-win/curl-for-win/curl/src/tool_operate.c:107:28: note: previous declaration of 'curl_ca_embed' was here
  107 | extern const unsigned char curl_ca_embed[];
      |                            ^~~~~~~~~~~~~

https://github.com/curl/curl-for-win/actions/runs/11192203640/job/31116070669#step:3:4894

Follow-up to 8a3740b #14059

Seen with curl-for-win linux-musl-from-mac build with gcc 9.2.0.

```
n file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:136:
/Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/tool_ca_embed.c:4:28: warning: redundant redeclaration of 'curl_ca_embed' [-Wredundant-decls]
    4 | extern const unsigned char curl_ca_embed[];
      |                            ^~~~~~~~~~~~~
In file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:88:
/Users/runner/work/curl-for-win/curl-for-win/curl/src/tool_operate.c:107:28: note: previous declaration of 'curl_ca_embed' was here
  107 | extern const unsigned char curl_ca_embed[];
      |                            ^~~~~~~~~~~~~
```
https://github.com/curl/curl-for-win/actions/runs/11192203640/job/31116070669#step:3:4894
@dfandrich

Copy link
Copy Markdown
Contributor

Analysis of PR #15307 at e2add64b:

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-0--2] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-0--1] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-0-0] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-1--2] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-1--1] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-1-0] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test http/test_17_ssl_use.py::TestSSLUse::test_17_09_ssl_min_max[TLSv1-2--2] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

There are more failures, but that's enough from Gha.

Generated by Testclutch

@vszakats

Copy link
Copy Markdown
Member Author

@vszakats
vszakats marked this pull request as ready for review October 16, 2024 14:09
@vszakats vszakats closed this in 6478a36 Oct 16, 2024
@vszakats
vszakats deleted the src-double-declare-ca-embed branch October 16, 2024 15:28
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
Seen with curl-for-win linux-musl-from-mac build with gcc 9.2.0.

```
n file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:136:
/Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/tool_ca_embed.c:4:28: warning: redundant redeclaration of 'curl_ca_embed' [-Wredundant-decls]
    4 | extern const unsigned char curl_ca_embed[];
      |                            ^~~~~~~~~~~~~
In file included from /Users/runner/work/curl-for-win/curl-for-win/curl/_x64-linux-musl-bld/src/CMakeFiles/curl.dir/Unity/unity_0_c.c:88:
/Users/runner/work/curl-for-win/curl-for-win/curl/src/tool_operate.c:107:28: note: previous declaration of 'curl_ca_embed' was here
  107 | extern const unsigned char curl_ca_embed[];
      |                            ^~~~~~~~~~~~~
```
https://github.com/curl/curl-for-win/actions/runs/11192203640/job/31116070669#step:3:4894

Follow-up to 8a3740b curl#14059
Closes curl#15307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants