Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winbuild/README: consolidate command prompt section #15313

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Oct 16, 2024

  • Remove reference to 'Developer Command Prompt for Visual Studio' shortcut since it opens in x86 mode.

That prompt may confuse users since it is not easily switched to x64. Our instruction says vcvarsall can be used to change the platform but it is not in the path in any version that I checked (VS 2010, 2013, 2022) and if it is invoked manually it appends to the path.

Instead users will now only see the remaining instruction to use a platform specific command prompt to build curl, like "x64 Native Tools".

There's several links as well to Microsoft documentation for users that have more complicated requirements, such as using vcvarsall.

Closes #xxxx

/cc @kdekker

@jay jay added documentation Windows Windows-specific labels Oct 16, 2024
@github-actions github-actions bot added the build label Oct 16, 2024
@bagder
Copy link
Member

bagder commented Oct 17, 2024

I'm addressing the proselint craziness here: #15314

- Remove reference to 'Developer Command Prompt for Visual Studio'
  shortcut since it opens in x86 mode.

That prompt may confuse users since it is not easily switched to x64.
Our instruction says vcvarsall can be used to change the platform but it
is not in the path in any version that I checked (VS 2010, 2013, 2022)
and if it is invoked manually it appends to the path.

Instead users will now only see the remaining instruction to use a
platform specific command prompt to build curl, like "x64 Native Tools".

There's several links as well to Microsoft documentation for users that
have more complicated requirements, such as using vcvarsall.

Closes #xxxx
@jay jay closed this in 22e7b15 Oct 30, 2024
@jay jay deleted the update2_winbuild_README branch October 30, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants