Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: say quictls in MSH3 builds #15335

Closed
wants to merge 2 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Oct 18, 2024

Before: curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV OpenSSL/3.3.0 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2 msh3/0.6.0.0
After: curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV quictls/3.3.0 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2 msh3/0.6.0.0

@github-actions github-actions bot added the TLS label Oct 18, 2024
@vszakats vszakats marked this pull request as draft October 18, 2024 23:05
@vszakats vszakats added the HTTP/3 h3 or quic related label Oct 18, 2024
@dfandrich
Copy link
Contributor

Analysis of PR #15335 at e841ce2a:

Test 3001 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 3 different CI jobs (the link just goes to one of them).

Generated by Testclutch

@vszakats vszakats marked this pull request as ready for review October 19, 2024 09:34
@vszakats
Copy link
Member Author

vszakats commented Oct 19, 2024

Seems like something fell apart due to updated vcpkg packages.
This was good yesterday:

curl 8.11.0-DEV (Windows) libcurl/8.11.0-DEV OpenSSL/3.3.2 zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 c-ares/1.33.1 libpsl/0.21.5 libssh2/1.11.0 nghttp2/1.62.1 nghttp3/1.5.0 libgsasl/2.2.1

https://github.com/curl/curl/actions/runs/11398476918/job/31715590303#step:10:33

Since updating to these, it pretty much always fails with timeout/hang/fail and on test 987 "SMTPS with redundant explicit SSL request":

curl 8.11.0-DEV (Windows) libcurl/8.11.0-DEV OpenSSL/3.3.2 zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 c-ares/1.34.1 libpsl/0.21.5 libssh2/1.11.0 nghttp2/1.63.0 nghttp3/1.6.0 libgsasl/2.2.1

https://github.com/curl/curl/actions/runs/11412281667/job/31767765615?pr=15335#step:10:33
https://github.com/curl/curl/actions/runs/11416403197/job/31767851195?pr=15331#step:13:4282

It doesn't pass for the 5th retry which never happened before. (it almost always passes the first retry)

The other consistently unstable job:
Good yesterday:

curl 8.11.0-DEV (Windows) libcurl/8.11.0-DEV (mbedTLS/3.6.1) (OpenSSL/3.3.2) Schannel zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 WinIDN libpsl/0.21.5 libssh2/1.11.0 nghttp2/1.62.1 libgsasl/2.2.1

https://github.com/curl/curl/actions/runs/11398476918/job/31715589834#step:10:30

Bad today:

curl 8.11.0-DEV (Windows) libcurl/8.11.0-DEV (mbedTLS/3.6.1) (OpenSSL/3.3.2) Schannel zlib/1.3.1 brotli/1.1.0 zstd/1.5.6 WinIDN libpsl/0.21.5 libssh2/1.11.0 nghttp2/1.63.0 libgsasl/2.2.1

https://github.com/curl/curl/actions/runs/11412281667/job/31767765455?pr=15335#step:10:30

But it might not be something to do with the actual dependencies, but with something broken again in the
latest windows-image update.

Good: 20241006.1.0
Bad: 20241015.1.0

This image is not yet released officially.

@vszakats vszakats closed this in 7dd7cba Oct 21, 2024
@vszakats vszakats deleted the version-quictls-msh3 branch October 21, 2024 10:48
vszakats added a commit to vszakats/curl that referenced this pull request Oct 22, 2024
987 is `SMTPS with redundant explicit SSL request`

Started failing after GHA bumping the windows image to `20241015.1.0`:
actions/runner-images@fcc4cdb
actions/runner-images#10803

vcpkg packages also got bumped as a result. They seem unrelated:
c-ares  1.33.1 -> 1.34.1
nghttp2 1.62.1 -> 1.63.0
nghttp3 1.5.0  -> 1.6.0
(there may be more)

Ref: curl#15335 (comment)
vszakats added a commit that referenced this pull request Oct 22, 2024
987 is `SMTPS with redundant explicit SSL request`.

Root cause undiscovered.

Started failing after GHA bumping the windows image to `20241015.1.0`:
actions/runner-images@fcc4cdb
actions/runner-images#10803

vcpkg packages also got bumped as a result. They seem unrelated:
c-ares  1.33.1 -> 1.34.1
nghttp2 1.62.1 -> 1.63.0
nghttp3 1.5.0  -> 1.6.0
(there may be more)

Ref: #15335 (comment)

Closes #15356
vszakats added a commit to vszakats/curl that referenced this pull request Oct 22, 2024
The openssl job in particular no longer fits into 10 minutes since
the 20241015.1.0 GHA windows-latest image update.
The `run tests` step takes ~10 minutes now, up from ~4. That is
6 minutes more than before these updates.

c-ares got bumped from 1.33.1 to 1.34.1 in vcpkg and the affected
vcpkg job is the only one using this dependency.

It may be the reason for this regression.

Before:
https://github.com/curl/curl/actions/runs/11386748199/job/31679733295
https://github.com/curl/curl/actions/runs/11347976608/job/31560690219

After:
https://github.com/curl/curl/actions/runs/11462332743/job/31893491625?pr=15364

Ref: curl#15335 (comment)
vszakats added a commit that referenced this pull request Oct 22, 2024
The openssl job no longer fits into 10 minutes since the 20241015.1.0
GHA windows-latest image update. This caused all runs to fail.

The `run tests` step takes ~10 minutes now, up from ~4. This is
6 minutes more than before these updates. It's seen with other vcpkg
jobs too, tests run slower than half speed since.

Bump the timeout to make it, though the headroom is now less than it
was.

Before:
https://github.com/curl/curl/actions/runs/11386748199/job/31679733295
https://github.com/curl/curl/actions/runs/11347976608/job/31560690219

After:
https://github.com/curl/curl/actions/runs/11462332743/job/31893491625?pr=15364

Ref: actions/runner-images@fcc4cdb
Ref: #15335 (comment)
Follow-up to 1e03059 #15356
Closes #15364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HTTP/3 h3 or quic related TLS
Development

Successfully merging this pull request may close these issues.

2 participants