version: say quictls in MSH3 builds - #15335
Closed
vszakats wants to merge 2 commits into
Closed
Conversation
Contributor
|
Analysis of PR #15335 at e841ce2a: Test 3001 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 3 different CI jobs (the link just goes to one of them). Generated by Testclutch |
vszakats
marked this pull request as ready for review
October 19, 2024 09:34
Member
Author
|
Seems like something fell apart due to updated vcpkg packages. https://github.com/curl/curl/actions/runs/11398476918/job/31715590303#step:10:33 Since updating to these, it pretty much always fails with timeout/hang/fail and on test 987 "SMTPS with redundant explicit SSL request": https://github.com/curl/curl/actions/runs/11412281667/job/31767765615?pr=15335#step:10:33 It doesn't pass for the 5th retry which never happened before. (it almost always passes the first retry) The other consistently unstable job: https://github.com/curl/curl/actions/runs/11398476918/job/31715589834#step:10:30 Bad today: https://github.com/curl/curl/actions/runs/11412281667/job/31767765455?pr=15335#step:10:30 But it might not be something to do with the actual dependencies, but with something broken again in the Good: 20241006.1.0 This image is not yet released officially. |
vszakats
force-pushed
the
version-quictls-msh3
branch
from
October 19, 2024 23:17
e841ce2 to
f507e1e
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 22, 2024
987 is `SMTPS with redundant explicit SSL request` Started failing after GHA bumping the windows image to `20241015.1.0`: actions/runner-images@fcc4cdb actions/runner-images#10803 vcpkg packages also got bumped as a result. They seem unrelated: c-ares 1.33.1 -> 1.34.1 nghttp2 1.62.1 -> 1.63.0 nghttp3 1.5.0 -> 1.6.0 (there may be more) Ref: curl#15335 (comment)
vszakats
added a commit
that referenced
this pull request
Oct 22, 2024
987 is `SMTPS with redundant explicit SSL request`. Root cause undiscovered. Started failing after GHA bumping the windows image to `20241015.1.0`: actions/runner-images@fcc4cdb actions/runner-images#10803 vcpkg packages also got bumped as a result. They seem unrelated: c-ares 1.33.1 -> 1.34.1 nghttp2 1.62.1 -> 1.63.0 nghttp3 1.5.0 -> 1.6.0 (there may be more) Ref: #15335 (comment) Closes #15356
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 22, 2024
The openssl job in particular no longer fits into 10 minutes since the 20241015.1.0 GHA windows-latest image update. The `run tests` step takes ~10 minutes now, up from ~4. That is 6 minutes more than before these updates. c-ares got bumped from 1.33.1 to 1.34.1 in vcpkg and the affected vcpkg job is the only one using this dependency. It may be the reason for this regression. Before: https://github.com/curl/curl/actions/runs/11386748199/job/31679733295 https://github.com/curl/curl/actions/runs/11347976608/job/31560690219 After: https://github.com/curl/curl/actions/runs/11462332743/job/31893491625?pr=15364 Ref: curl#15335 (comment)
vszakats
added a commit
that referenced
this pull request
Oct 22, 2024
The openssl job no longer fits into 10 minutes since the 20241015.1.0 GHA windows-latest image update. This caused all runs to fail. The `run tests` step takes ~10 minutes now, up from ~4. This is 6 minutes more than before these updates. It's seen with other vcpkg jobs too, tests run slower than half speed since. Bump the timeout to make it, though the headroom is now less than it was. Before: https://github.com/curl/curl/actions/runs/11386748199/job/31679733295 https://github.com/curl/curl/actions/runs/11347976608/job/31560690219 After: https://github.com/curl/curl/actions/runs/11462332743/job/31893491625?pr=15364 Ref: actions/runner-images@fcc4cdb Ref: #15335 (comment) Follow-up to 1e03059 #15356 Closes #15364
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Before: `curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV OpenSSL/3.3.0 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2 msh3/0.6.0.0` After: `curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV quictls/3.3.0 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2 msh3/0.6.0.0` Closes curl#15335
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
987 is `SMTPS with redundant explicit SSL request`. Root cause undiscovered. Started failing after GHA bumping the windows image to `20241015.1.0`: actions/runner-images@fcc4cdb actions/runner-images#10803 vcpkg packages also got bumped as a result. They seem unrelated: c-ares 1.33.1 -> 1.34.1 nghttp2 1.62.1 -> 1.63.0 nghttp3 1.5.0 -> 1.6.0 (there may be more) Ref: curl#15335 (comment) Closes curl#15356
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
The openssl job no longer fits into 10 minutes since the 20241015.1.0 GHA windows-latest image update. This caused all runs to fail. The `run tests` step takes ~10 minutes now, up from ~4. This is 6 minutes more than before these updates. It's seen with other vcpkg jobs too, tests run slower than half speed since. Bump the timeout to make it, though the headroom is now less than it was. Before: https://github.com/curl/curl/actions/runs/11386748199/job/31679733295 https://github.com/curl/curl/actions/runs/11347976608/job/31560690219 After: https://github.com/curl/curl/actions/runs/11462332743/job/31893491625?pr=15364 Ref: actions/runner-images@fcc4cdb Ref: curl#15335 (comment) Follow-up to 1e03059 curl#15356 Closes curl#15364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV OpenSSL/3.3.0 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2 msh3/0.6.0.0After:
curl 8.11.0-DEV (x86_64-pc-linux-gnu) libcurl/8.11.0-DEV quictls/3.3.0 zlib/1.3 brotli/1.1.0 zstd/1.5.5 libpsl/0.21.2 msh3/0.6.0.0