cmake/FindCares: fix version detection for c-ares 1.34.1 - #15368
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
Regression in 1.34.1, fixed in 1.34.2. Make sure we detect version also for the 1.34.1 version. c-ares/c-ares@126e274 c-ares/c-ares#903
vszakats
changed the title
vszakats
changed the title
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Due to a regression in c-ares 1.34.1, the non-pkg-config version detection method broke for this version. c-ares 1.34.2 fixes it, but update our detection code anyway to also work with 1.34.1. Ref: c-ares/c-ares@126e274 c-ares/c-ares#903 Closes curl#15368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a regression in c-ares 1.34.1, the non-pkg-config version
detection method broke for this version. c-ares 1.34.2 fixes it,
but update our detection code anyway to also work with 1.34.1.
Ref:
c-ares/c-ares@126e274
c-ares/c-ares#903