Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mk-lib1521.pl: fix the long return code check #15372

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Oct 22, 2024

It worked mostly by accident since it checked the variable from the previous setopt invoke.

Bonus: this disables deprecation differently. Using the CURL_IGNORE_DEPRECATION() style works, but it makes the code infuriatingly annoying to work with when single-stepping in a debugger.

@bagder
Copy link
Member Author

bagder commented Oct 22, 2024

Hm, this isn't easy to fix in a nice and clean way...

@bagder
Copy link
Member Author

bagder commented Oct 22, 2024

The reason the existing macro is bad to use in lib1521 is that it effectively prevents us from setting a break-point in lib1521.c with a debugger inside that macro, and it also breaks single-stepping. This makes debugging super annoying and downright complicated.

@bagder
Copy link
Member Author

bagder commented Oct 22, 2024

GGGGGGGGGG

@bagder
Copy link
Member Author

bagder commented Oct 22, 2024

I'll drop the deprecation part from this PR and come back to it later.

It worked mostly by accident since it checked the variable from the
previous setopt invoke.
@dfandrich
Copy link
Contributor

Analysis of PR #15372 at 92e6b3fd:

Test 1193 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1196 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 2201 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 2205 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1452 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants