[ngtcp2] set max window size to 10x of initial (128KB), as the quiche backend does - #15392
Closed
kazuho wants to merge 1 commit into
Closed
[ngtcp2] set max window size to 10x of initial (128KB), as the quiche backend does#15392kazuho wants to merge 1 commit into
kazuho wants to merge 1 commit into
Conversation
icing
approved these changes
Oct 24, 2024
Member
|
Thanks! |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Just as the quiche backend does Closes curl#15392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QUIC backends use flow control windows initially set to 128KB. In #14880, the maximum size used by the quiche backend was increased to 1280KB, but that of the ngtcp2 backend remained at 128KB.
With a window size of 128KB, the sustained maximum throughput with the ngtcp2 backend has been equivalent to TCP without the window scaling option (note: ngtcp2 sends MAX_STREAM_DATA when 1/2 the window is consumed, while TCP updates the window size with each ACK).
This PR changes the ngtcp2 backend to use the same maximum (1280KB) as the quiche backend does.